-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(fix): testing the serializability behaviour without relying on t…
…he underlying concurrency (#1079) fix #497 Since we are testing the behaviour _(i.e. if two transactions conflict with each other, the database guarantees that only one can commit successfully at a time)_ now, both of the tests are now agnostic of underlying concurrency mechanism. This makes sure that both of the tests continue to pass in any gcloud project .
- Loading branch information
Showing
2 changed files
with
155 additions
and
38 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/StatementExecutor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Copyright 2023 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.datastore.it; | ||
|
|
||
| import static java.util.concurrent.TimeUnit.SECONDS; | ||
|
|
||
| import com.google.cloud.Tuple; | ||
| import com.google.cloud.datastore.DatastoreException; | ||
| import com.google.common.collect.ArrayListMultimap; | ||
| import com.google.common.collect.Multimap; | ||
| import java.util.concurrent.ExecutionException; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.Future; | ||
| import java.util.concurrent.TimeoutException; | ||
|
|
||
| /** | ||
| * An executor class to handle interleaved transactions. | ||
| * | ||
| * <p>It executes statements (under multiple transactions) and record their failures under a groupId | ||
| * provided by users. | ||
| */ | ||
| class StatementExecutor { | ||
|
|
||
| private final Multimap<String, Exception> failures = ArrayListMultimap.create(); | ||
|
|
||
| /** | ||
| * Executes a list of {@link Statement} one by one and record their failures under the groupId. In | ||
| * case of pessimistic concurrency, a statement will be blocked and cause delay until another | ||
| * transaction which was started earlier is committed. In case of optimistic concurrency, both | ||
| * transaction can perform their operation simultaneously, but the one which commits first will be | ||
| * a winner and other one will get an error on commit operation indicating a need for retry. | ||
| * | ||
| * @param tuples A {@link Statement(String, String) Tuple(<String, Statement>)} has a | ||
| * groupId of {@link String} type and a {@link Statement} to execute. | ||
| */ | ||
| @SafeVarargs | ||
| final void execute(Tuple<String, Statement>... tuples) throws Exception { | ||
| ExecutorService executorService = Executors.newSingleThreadExecutor(); | ||
| for (Tuple<String, Statement> tuple : tuples) { | ||
| String groupId = tuple.x(); | ||
| Statement statement = tuple.y(); | ||
| Future<?> future = executorService.submit(statement::execute); | ||
| try { | ||
| // waiting for statement to execute | ||
| future.get(10, SECONDS); | ||
| } catch (Exception exception) { | ||
| future.cancel(true); | ||
| if (transactionConflict(exception)) { | ||
| failures.put(groupId, exception); | ||
| } else { | ||
| throw exception; | ||
| } | ||
| } | ||
| } | ||
| executorService.shutdown(); | ||
| } | ||
|
|
||
| boolean didAllPass(String groupId) { | ||
| return failures.get(groupId).isEmpty(); | ||
| } | ||
|
|
||
| private boolean transactionConflict(Exception exception) { | ||
| if (exception instanceof TimeoutException) { // timed out coz of pessimistic concurrency delay | ||
| return true; | ||
| } | ||
| return exception instanceof ExecutionException | ||
| && exception.getCause().getClass() == DatastoreException.class | ||
| && exception | ||
| .getMessage() | ||
| .contains("contention"); // exception raise coz of optimistic concurrency | ||
| } | ||
|
|
||
| interface Statement { | ||
| void execute(); | ||
| } | ||
| } |