test(fix): testing the serializability behaviour without relying on the underlying concurrency #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…underlying concurrency implementation details
product-auto-label
bot
added
size: m
kolea2
reviewed
May 17, 2023
google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITDatastoreTest.java
Show resolved
Hide resolved
google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/StatementExecutor.java
Outdated
Show resolved
Hide resolved
kolea2
approved these changes
May 18, 2023
kolea2
changed the title
jainsahab
changed the title
jainsahab
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #497
Since we are testing the behaviour (i.e. if two transactions conflict with each other, the database guarantees that only one can commit successfully at a time) now, both of the tests are now agnostic of underlying concurrency mechanism. This makes sure that both of the tests continue to pass in any gcloud project .