Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: change routing to remove location parameter in preparation for the addition of regional support #178

Merged
merged 3 commits into from Jun 3, 2020

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented May 12, 2020

This PR was generated using Autosynth. 馃寛

Synth log will be available here:
https://source.cloud.google.com/results/invocations/0ba8d2f8-7f35-417b-8c9a-d829ca01eac0/targets

PiperOrigin-RevId: 311164352
Source-Link: googleapis/googleapis@1b8b77d

BREAKING CHANGE: Location name helpers have been removed in preparation for regionalization support. Please use a parent string directly instead.

鈥rent instead of having it's own parameter. API still remain global only, but prepares for the addition of regional support.

PiperOrigin-RevId: 311164352

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue May 12 11:15:22 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 1b8b77db10a0bd0ff47a4259ae9804b6237bc1c7
Source-Link: googleapis/googleapis@1b8b77d
@googlebot googlebot added the cla: yes label May 12, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 3, 2020

Codecov Report

Merging #178 into master will increase coverage by 3.65%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
+ Coverage     70.85%   74.50%   +3.65%     
+ Complexity      226      213      -13     
============================================
  Files             6        6              
  Lines          2007     1859     -148     
  Branches         62       47      -15     
============================================
- Hits           1422     1385      -37     
+ Misses          542      437     -105     
+ Partials         43       37       -6     
Impacted Files Coverage 螖 Complexity 螖
...java/com/google/cloud/dlp/v2/DlpServiceClient.java 51.96% <66.66%> (+5.86%) 124.00 <3.00> (-13.00) 猬嗭笍
...m/google/cloud/dlp/v2/stub/GrpcDlpServiceStub.java 98.23% <100.00%> (酶) 40.00 <0.00> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update be82169...b215458. Read the comment docs.

@chingor13 chingor13 changed the title Cloud DLP - fix routing for gRPC clients by embedding location into parent instead of having it's own parameter. API still remain global only, but prepares for the addition of regional support. fix!: change routing to remove location parameter in preparation for the addition of regional support Jun 3, 2020
@chingor13 chingor13 added the automerge label Jun 3, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4be3740 into master Jun 3, 2020
14 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the autosynth-googleapis branch Jun 3, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 23, 2020
馃 I have created a release \*beep\* \*boop\* 
---
## [2.0.0](https://www.github.com/googleapis/java-dlp/compare/v1.1.4...v2.0.0) (2020-06-22)


###  BREAKING CHANGES

* Location name helpers have been removed in preparation for regionalization support. Please use a parent string directly instead.

### Features

* add WORD and PDF file type enums and new MetadataLocation proto ([#176](https://www.github.com/googleapis/java-dlp/issues/176)) ([12aeb68](https://www.github.com/googleapis/java-dlp/commit/12aeb68a7626eecccc877bdc993e89150991718c)), closes [#533](https://www.github.com/googleapis/java-dlp/issues/533) [#535](https://www.github.com/googleapis/java-dlp/issues/535)
* **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([#212](https://www.github.com/googleapis/java-dlp/issues/212)) ([8039912](https://www.github.com/googleapis/java-dlp/commit/8039912581d117e07c96f64440b8b4c2263296fc))


### Bug Fixes

* change routing to remove location parameter in preparation for the addition of regional support ([#178](https://www.github.com/googleapis/java-dlp/issues/178)) ([4be3740](https://www.github.com/googleapis/java-dlp/commit/4be3740cf5fc967b7ba84a53c9d568f0d8502308))


### Dependencies

* update dependency com.google.api:api-common to v1.9.1 ([#187](https://www.github.com/googleapis/java-dlp/issues/187)) ([ef3a106](https://www.github.com/googleapis/java-dlp/commit/ef3a106e19a2e3b7fc62fe7e1ad7fac476168d09))
* update dependency com.google.api:api-common to v1.9.2 ([#194](https://www.github.com/googleapis/java-dlp/issues/194)) ([1584607](https://www.github.com/googleapis/java-dlp/commit/1584607c7e36d3a074dea94d3b6ff2a242f8e9c9))
* update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 ([#173](https://www.github.com/googleapis/java-dlp/issues/173)) ([a1b65d4](https://www.github.com/googleapis/java-dlp/commit/a1b65d4fb390533ba5a92d03bfe482455ef43163))
* update dependency com.google.protobuf:protobuf-java to v3.12.0 ([#180](https://www.github.com/googleapis/java-dlp/issues/180)) ([546af1c](https://www.github.com/googleapis/java-dlp/commit/546af1cd30706075872e9ebe2bdb0dcc1387cb80))
* update dependency com.google.protobuf:protobuf-java to v3.12.2 ([#185](https://www.github.com/googleapis/java-dlp/issues/185)) ([4cf7620](https://www.github.com/googleapis/java-dlp/commit/4cf76208bc70e1ac6e02757fb7c7c41dad4cc381))
* update dependency io.grpc:grpc-bom to v1.30.0 ([#198](https://www.github.com/googleapis/java-dlp/issues/198)) ([0701b8f](https://www.github.com/googleapis/java-dlp/commit/0701b8f3fc11ddd3b159d7584e90736f98d594a4))


### Documentation

* regenerate with fixed URLs and new protoc ([#192](https://www.github.com/googleapis/java-dlp/issues/192)) ([16d6d74](https://www.github.com/googleapis/java-dlp/commit/16d6d7486b36ccbfeca3c026226848fc55b0004a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge cla: yes context: full
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants