Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sample to list available logs #358

Closed
0xSage opened this issue Dec 10, 2020 · 2 comments · Fixed by #602
Closed

Add sample to list available logs #358

0xSage opened this issue Dec 10, 2020 · 2 comments · Fixed by #602
Assignees
@minherz
Labels
api: logging Issues related to the googleapis/java-logging API. good first issue This issue is a good place to started contributing to this repository. lang: java Issues specific to Java. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.

Comments

@0xSage
Copy link
Contributor

0xSage commented Dec 10, 2020 •
edited
Loading

Similar to this Nodejs sample, add a Java sample showcasing getting available logs & accompanying test(s).

Region tag: logging_list_logs
@0xSage 0xSage added good first issue This issue is a good place to started contributing to this repository. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 10, 2020
@product-auto-label product-auto-label bot added api: logging Issues related to the googleapis/java-logging API. samples Issues that are directly related to samples. labels Dec 10, 2020
@simonz130 simonz130 self-assigned this Dec 10, 2020
@simonz130 simonz130 added the lang: java Issues specific to Java. label Dec 10, 2020
@simonz130 simonz130 added the type: docs Improvement to the documentation for an API. label May 18, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 8, 2021
@daniel-sanche daniel-sanche added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 17, 2021
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jun 18, 2021
@simonz130 simonz130 assigned minherz and unassigned simonz130 Jul 14, 2021
@simonz130
Copy link

@minherz - could you please look into this?

@minherz
Copy link
Contributor

minherz commented Jul 27, 2021

Depends on #593.

minherz added a commit that referenced this issue Jul 30, 2021
@minherz
feat: add listLogs snippet example
48b3a18 
Add a sample snippet to demonstrate use of listLogs API.
Refactor ListLogs to include snippets for listLogs and listLogEntries.
Format all snippets.

Fixes #358.
@minherz minherz mentioned this issue Jul 30, 2021
Merged
minherz added a commit that referenced this issue Aug 8, 2021
@minherz
feat: add listLogs snippet example
1f73b70 
Add a sample snippet to demonstrate use of listLogs API.
Refactor ListLogs to include snippets for listLogs and listLogEntries.
Format all snippets.

Fixes #358.
minherz added a commit that referenced this issue Aug 11, 2021
@minherz
feat: add listLogs snippet example
6be2f35 
Add a sample snippet to demonstrate use of listLogs API.
Refactor ListLogs to include snippets for listLogs and listLogEntries.
Format all snippets.

Fixes #358.
minherz added a commit that referenced this issue Aug 12, 2021
@minherz
feat: add listLogs snippet example
b81f8a0 
Add a sample snippet to demonstrate use of listLogs API.
Refactor ListLogs to include snippets for listLogs and listLogEntries.
Format all snippets.

Fixes #358.
minherz added a commit that referenced this issue Aug 12, 2021
@minherz
feat: implement listLogs API and provide sample snippet (#602)
9359569 
* feat: add listLogs and listLogsAsync to Logging

Add listLogs API support to hand-written layer of google-cloud-logging.
Add unit testing for the new listLogs API.

Fixes #593

* feat: add listLogs snippet example

Add a sample snippet to demonstrate use of listLogs API.
Refactor ListLogs to include snippets for listLogs and listLogEntries.
Format all snippets.

Fixes #358.

* chore: set generated serialVersionUID for LogNamePageFetcher

* chore(code): fixing errors

* chore(deps): fix clirr plugin 7012 error

Because of JDK 1.7 it is impossible to provide default implementation
for new interface methods.
File with exclusions is added instead. The file should be removed once
JDK version is upgraded.

* chore(tests): fix samples' tests

Fix printed string in LogEntryWriteHttpRequest.createLogEntryRequest().
Fix loops to wait for any data in STDOUT.
Add test for listLogs snippet.

* chore(test): forward exception throwing

Update testListLogNames() signature to throw exceptions

* chore(tests): refactoring tests

Test ListLogs.printLogNames vs audit logs to save time.
Restore retrieval of log entries in the wait loop to ensure printing to STDOUT

* chore(tests): fine tune clirr exceptions

Provide method level exception configuration in clirr-ignored-differences.
Implement default methods for new methods in Logging and LoggingRpc interfaces.
Following guidelines, remove serialVersionUID from LogNamePageFetcher.

* chore: refactoring method naming and sample snippets

Make more verbose naming for methods.
Refactor testing after renaming interface method(s).
Split ListLogs sample into two: ListLogEntries and ListLogs.

* chore(fix): fix formatting

* chore(comment): fix copyright year of the new file

* chore(fix): restore sample filter to list log entries

update the list log entries filter to bring results only for the last hour.

* chore(fix): fix snippet-bot errors

adding empty region tag logging_list_log_entries to ListLogs.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minherz minherz

Labels
api: logging Issues related to the googleapis/java-logging API. good first issue This issue is a good place to started contributing to this repository. lang: java Issues specific to Java. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement listLogs API and provide sample snippet googleapis/java-logging
5 participants
@daniel-sanche @minherz @simonz130 @yoshi-automation @0xSage