-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PSL Connector Writer support #121
Conversation
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
============================================
+ Coverage 58.96% 59.52% +0.55%
- Complexity 92 129 +37
============================================
Files 18 24 +6
Lines 580 751 +171
Branches 24 31 +7
============================================
+ Hits 342 447 +105
- Misses 232 296 +64
- Partials 6 8 +2
Continue to review full report at Codecov.
|
src/main/java/com/google/cloud/pubsublite/spark/PslDataWriterFactory.java
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/CachedPublishers.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/CachedPublishers.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/CachedPublishers.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslCredentialsProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/CachedPublishers.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslDataWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslSparkUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslWriteDataSourceOptions.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after remaining fixes, ping me after those are done.
src/main/java/com/google/cloud/pubsublite/spark/PslDataWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslDataWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslSparkUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslSparkUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslSparkUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/PslWriteDataSourceOptions.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/cloud/pubsublite/spark/internal/CachedPublishers.java
Outdated
Show resolved
Hide resolved
clirr is going to be mad about this PR, you'll need to add allowed exceptions for all the things you've moved to an internal file. Also, look at the clirr file for the main library and allow breaking changes in all internal directories. |
No description provided.