test: OptionsTest checks for fixed values being returned from hashCode() #577
Labels
api: spanner
Issues related to the googleapis/java-spanner API.
good first issue
This issue is a good place to started contributing to this repository.
help wanted
We'd love to have community involvement on this issue.
type: cleanup
An internal cleanup or hygiene concern.
Comments
olavloite
added
help wanted
product-auto-label
bot
added
the
api: spanner
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this issue
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#3952 Changes: feat!: Refactored Elliptic Key curves to provide additional options, the NamedCurve enum is replaced by the EcKeyType message. PiperOrigin-RevId: 368757092 Source-Link: googleapis/googleapis@b1c23ed chore(gaming): migrate gaming/{v1, v1beta} to the PHP microgenerator Committer: @miraleung PiperOrigin-RevId: 368737560 Source-Link: googleapis/googleapis@001f72d chore(oslogin): remove unnecessary gapic.yaml for oslogin Committer: @miraleung PiperOrigin-RevId: 368733985 Source-Link: googleapis/googleapis@9ee1b71 chore: release gapic-generator-php v0.1.0 Committer: @miraleung PiperOrigin-RevId: 368733958 Source-Link: googleapis/googleapis@bd72b41 docs(datacatalog): reformat comments in PolicyTagManager definition PiperOrigin-RevId: 368687296 Source-Link: googleapis/googleapis@91eee3d
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this issue
Nov 17, 2022
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this issue
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [2.4.0](https://www.github.com/googleapis/java-spanner-jdbc/compare/v2.3.5...v2.4.0) (2021-08-27) ### Features * support JSON data type ([googleapis#447](https://www.github.com/googleapis/java-spanner-jdbc/issues/447)) ([ca1c906](https://www.github.com/googleapis/java-spanner-jdbc/commit/ca1c906e1ed3cad6444068ab9c8465401d6d3074)) ### Dependencies * update dependency com.google.cloud:google-cloud-spanner-bom to v6.12.1 ([googleapis#577](https://www.github.com/googleapis/java-spanner-jdbc/issues/577)) ([a78b177](https://www.github.com/googleapis/java-spanner-jdbc/commit/a78b177f97c298a5b43fcadbca125e957e9f781a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
Options#hashCode()method does not guarantee to return a fixed value that is equal on all JVM's (at least; the documentation does not guarantee it). In reality it does, because the current implementation only uses hash codes that are guaranteed to be equal on all JVM's. The method should either be documented to have this behavior, or these tests should be replaced with tests that assert that thehashCodeandequalsmethods comply with the general contract regarding these methods.The text was updated successfully, but these errors were encountered: