Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test allowed a too old staleness #214

Merged
merged 1 commit into from Jun 5, 2020
Merged

fix: test allowed a too old staleness #214

merged 1 commit into from Jun 5, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented May 15, 2020

Fixes an issue that the test would allow a too old staleness (10 seconds), while the test would only wait 100ms before actually start reading.

@googlebot googlebot added the cla: yes label May 15, 2020
@olavloite olavloite added the kokoro:force-run label May 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label May 16, 2020
@olavloite olavloite requested a review from skuruppu Jun 4, 2020
@olavloite
Copy link
Contributor Author

@olavloite olavloite commented Jun 4, 2020

@skuruppu Sorry, I forgot to add you as a reviewer for this PR. It was added because of a flaky test failure some time ago.

@skuruppu skuruppu merged commit f4fa6bf into master Jun 5, 2020
13 checks passed
@skuruppu skuruppu deleted the fix-staleness-in-test branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants