feat!: Point In Time Recovery (PITR) #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
thiagotnunes
added
the
do not merge
product-auto-label
bot
added
the
api: spanner
thiagotnunes
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
thiagotnunes
added
the
do not merge
olavloite
requested changes
Oct 1, 2020
This looks generally good to me. There is one integration test case that needs a small change.
There are also a number of generated code changes in this PR. I assume that those will be added through a separate PR, and removed from this.
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITPitrUpdateDatabaseTest.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITPitrUpdateDatabaseTest.java
Outdated
Show resolved
Hide resolved
olavloite
approved these changes
Oct 2, 2020
thiagotnunes
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
============================================
- Coverage 85.24% 85.19% -0.05%
- Complexity 2612 2620 +8
============================================
Files 144 145 +1
Lines 14208 14260 +52
Branches 1372 1376 +4
============================================
+ Hits 12111 12149 +38
- Misses 1526 1537 +11
- Partials 571 574 +3
Continue to review full report at Codecov.
|
|
Warning: This pull request is touching the following templated files:
|
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the |
google-cla
bot
added
cla: no
|
Warning: This pull request is touching the following templated files:
|
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the |
|
Warning: This pull request is touching the following templated files:
|
google-cla
bot
added
cla: yes
yoshi-code-bot
reviewed
Nov 16, 2020
Some suggestions could not be made:
- google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java
- lines 201-212
thiagotnunes
changed the title
Exposes earliest version time and version retention period fields in the database class.
Adds integration tests for updating the version retention period.
Adds create database tests for PITR and refactors the integration test class.
Separates PITR database tests into 2 files for clarity.
The feature is not supported in the emulator currently.
Addresses PR comment.
To compare version retention period and earliest version time.
Fixes formatting of the DatabaseInfo
Adds test to check for the throttled field in the update database ddl metadata.
Adds more explanations to the purpose of the added params for pitr-lite: version_retention_period and earliest_version_time.
Adds PITR-lite version time to backups. This should make it possible to specify the consistent time for copying the database.
This is because the backend for these features is not ready yet.
thiagotnunes
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Implements the PITR-lite support.
With this functionality users will be able to set the retention period for their databases (through the
version_retention_perioddatabase field). Other than that, user should be able to specify the timestamp for a consistent copy of a database through theversion_timefield when creating a backup.