Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip failing backup tests for now #463

Merged

Conversation

thiagotnunes
Copy link
Contributor

@thiagotnunes thiagotnunes commented Sep 30, 2020

Restore/Backup operations filtering broken, skipping the tests that use it for now.

Until b/169431286 is fixed.
@thiagotnunes thiagotnunes requested a review from as a code owner Sep 30, 2020
@google-cla google-cla bot added the cla: yes label Sep 30, 2020
@thiagotnunes thiagotnunes requested review from olavloite and skuruppu Sep 30, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 30, 2020

Codecov Report

Merging #463 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #463      +/-   ##
============================================
+ Coverage     82.20%   82.25%   +0.04%     
- Complexity     2467     2472       +5     
============================================
  Files           138      138              
  Lines         13631    13631              
  Branches       1312     1312              
============================================
+ Hits          11206    11212       +6     
+ Misses         1896     1891       -5     
+ Partials        529      528       -1     
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/spanner/SpannerExceptionFactory.java 74.35% <0.00%> (+2.56%) 34.00% <0.00%> (+1.00%)
...gle/cloud/spanner/AsyncTransactionManagerImpl.java 76.27% <0.00%> (+6.77%) 12.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28103fb...990c612. Read the comment docs.

@thiagotnunes thiagotnunes merged commit f037f2d into googleapis:master Sep 30, 2020
18 of 19 checks passed
@thiagotnunes thiagotnunes deleted the skip-failing-backup-tests branch Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants