test: fix flaky InlineBeginTransactionTest #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query_ThenUpdate_ThenConsumeResultSet did not take into account that the session pool initialization will execute 4 BatchCreateSessions requests. These will normally be executed before the test transaction, but sometimes at least one of those requests might arrive after the transaction has started. That could cause the last 3 requests on the mock server to be different from what the test expected.
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
thiagotnunes
approved these changes
Nov 19, 2020
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#4684 Changes: build: use gapic-generator-typescript v2.4.1 Fixes builds that depend on google/cloud/location/locations.proto. Committer: @alexander-fenster PiperOrigin-RevId: 393385166 Source-Link: googleapis/googleapis@677caf0 docs(dialogflow/cx): clarified some LRO types docs: fixed some wrong update mask descriptions PiperOrigin-RevId: 393365899 Source-Link: googleapis/googleapis@4309574 feat: display_name is the display name for the assigned issue PiperOrigin-RevId: 393354400 Source-Link: googleapis/googleapis@8488545 chore: regenerate API index Source-Link: googleapis/googleapis@ccb7347 feat(monitoring/dashboard): Added support for logs-based alerts: https://cloud.google.com/logging/docs/alerting/log-based-alerts feat: Added support for user-defined labels on cloud monitoring's Service and ServiceLevelObjective objects fix!: mark required fields in QueryTimeSeriesRequest as required PiperOrigin-RevId: 393200011 Source-Link: googleapis/googleapis@354d076 feat: generate java files for error_reason.proto, bigquery_audit_metadata.proto and localized_text.proto PiperOrigin-RevId: 393186792 Source-Link: googleapis/googleapis@9e36f4e feat(assuredworkloads): Add Canada Regions And Support compliance regime fix: ResourceType CONSUMER_PROJECT is deprecated feat: ResourceType CONSUMER_FOLDER and KEYRING are added feat: display_name is added to ResourceSettings fix: billing_account is now optional in Workload feat: resource_settings is added to CreateWorkloadOperationMetadata Committer: @ketanbshah PiperOrigin-RevId: 393142547 Source-Link: googleapis/googleapis@4b6bb3d chore: update rules_gapic for build_gen change PiperOrigin-RevId: 393022593 Source-Link: googleapis/googleapis@4006aa5 chore(gkehub): update bazel BUILD PiperOrigin-RevId: 392995655 Source-Link: googleapis/googleapis@410f323 feat(cloudbuild/apiv1): Update cloudbuild proto with the service_account for BYOSA Triggers. Committer: @emoryruscus PiperOrigin-RevId: 392957767 Source-Link: googleapis/googleapis@5572865 fix: add missing annotation for batch document translation PiperOrigin-RevId: 392949968 Source-Link: googleapis/googleapis@41e44ac chore: cleanup deprecated Dataproc v1beta2 API references Committer: @medb PiperOrigin-RevId: 392937123 Source-Link: googleapis/googleapis@be31a88 chore(googleads): Disables `legacy_proto_load` on Node.js GAPICs Committer: @aohren PiperOrigin-RevId: 392917338 Source-Link: googleapis/googleapis@cdc9747 docs(workflows/executions): Correct the name of the corresponding wrapper library PiperOrigin-RevId: 392910344 Source-Link: googleapis/googleapis@dd50509 feat(cloudbuild/apiv1):add script field to BuildStep message PiperOrigin-RevId: 392761119 Source-Link: googleapis/googleapis@3cd708e chore: regenerate API index Source-Link: googleapis/googleapis@8a770c3 feat!: delete deprecated Dataproc v1beta2 API client Committer: @medb PiperOrigin-RevId: 392723737 Source-Link: googleapis/googleapis@8bf048d docs(retail): Keep the API doc up-to-date feat: update grpc service config settings to reflect correct API deadlines chore: remove relative private links from search service comments to prevent crashing client lib generation tool PiperOrigin-RevId: 392712211 Source-Link: googleapis/googleapis@cb637a6 chore: regenerate API index Source-Link: googleapis/googleapis@2760083 feat(gkehub): Add request_id under `DeleteMembershipRequest` and `UpdateMembershipRequest` feat: Add `OnPremCluster` and `MultiCloudCluster` as `GkeCluster` equivalent field fix!: Move `GkeCluster` under oneof PiperOrigin-RevId: 392706843 Source-Link: googleapis/googleapis@8c0e4a3
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.2](https://www.github.com/googleapis/java-spanner-jdbc/compare/v2.5.1...v2.5.2) (2021-11-11) ### Dependencies * update dependency com.google.cloud:google-cloud-spanner-bom to v6.15.2 ([googleapis#664](https://www.github.com/googleapis/java-spanner-jdbc/issues/664)) ([9f22c33](https://www.github.com/googleapis/java-spanner-jdbc/commit/9f22c331ee4c7340ed6f1b9f91a44ce1e4c5b792)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query_ThenUpdate_ThenConsumeResultSet did not take into account that the session pool initialization will execute 4 BatchCreateSessions requests. These will normally be executed before the test transaction, but sometimes at least one of those requests might arrive after the transaction has started. That could cause the last 3 requests on the mock server to be
different from what the test expected.