googleapis / java-spanner Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add sample for timeout for one RPC #707
Conversation
Adds a sample for setting a timeout for a single RPC. Fixes GoogleCloudPlatform/java-docs-samples#3805
samples/snippets/src/main/java/com/example/spanner/StatementTimeoutExample.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
=========================================
Coverage 85.05% 85.05%
Complexity 2556 2556
=========================================
Files 142 142
Lines 13930 13930
Branches 1326 1326
=========================================
Hits 11848 11848
Misses 1526 1526
Partials 556 556 Continue to review full report at Codecov.
|
@lesv Would you mind taking a second look at this PR? The PR is currently blocked from merging as you requested changes. |
@olavloite Apologies for the delay, what I'm concerned about is that we might test with many PR's / java version tests running at the same time, I'm concerned that you will have collisons. I was probably stuck on table names of Singers & Venues, but that's not really the problem since you are creating an instance and then deleting it. The code in I'm going to release my objection so you can move forward - again I missed the email or I'd have responded earlier. Apologies. If you believe I'm wrong in my concern, feel free to merge, if not could you fix it and explain where my understanding is flawed? |
I found the discussion. LGTM |
* docs: add sample for timeout for one RPC Adds a sample for setting a timeout for a single RPC. Fixes GoogleCloudPlatform/java-docs-samples#3805 * fix: fix import order * fix: format code with the correct formatter plugin * fix: delete test data after each test * fix: auto-throttle admin requests
Adds a sample for setting a timeout for a single RPC.
Fixes GoogleCloudPlatform/java-docs-samples#3805