Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reduce wait time for BackendExhaustedTest #835

Merged
merged 2 commits into from Feb 1, 2021

Conversation

olavloite
Copy link
Collaborator

The BackendExhaustedTest deliberately causes requests to get stuck on the mock server. This causes the Spanner instance to refuse to shutdown nicely and causes it to wait for 10 seconds. This can be circumvented by using shutdownNow() to force the closure of all gRPC transport channels. This reduces the overall build time with approx 10 seconds.

The BackendExhaustedTest deliberately causes requests to get stuck on the mock
server. This causes the Spanner instance to refuse to shutdown nicely and causes
it to wait for 10 seconds. This can be circumvented by using shutdownNow() to
force the closure of all gRPC transport channels. This reduces the overall build
time with approx 10 seconds.
@olavloite olavloite added the type: cleanup An internal cleanup or hygiene concern. label Jan 30, 2021
@olavloite olavloite requested a review from a team as a code owner January 30, 2021 16:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jan 30, 2021
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #835 (95b40b5) into master (facda8a) will decrease coverage by 0.04%.
The diff coverage is 64.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #835      +/-   ##
============================================
- Coverage     85.09%   85.04%   -0.05%     
- Complexity     2564     2585      +21     
============================================
  Files           143      143              
  Lines         14062    14145      +83     
  Branches       1348     1369      +21     
============================================
+ Hits          11966    12030      +64     
- Misses         1534     1542       +8     
- Partials        562      573      +11     
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/spanner/AbstractResultSet.java 83.60% <ø> (+0.30%) 28.00 <0.00> (ø)
...spanner/admin/database/v1/DatabaseAdminClient.java 83.22% <ø> (ø) 100.00 <0.00> (ø)
...a/com/google/cloud/spanner/SessionPoolOptions.java 70.31% <30.95%> (-19.35%) 19.00 <3.00> (+3.00) ⬇️
...ain/java/com/google/cloud/spanner/SpannerImpl.java 93.04% <66.66%> (-0.77%) 29.00 <0.00> (+1.00) ⬇️
...le/cloud/spanner/connection/ConnectionOptions.java 89.13% <88.57%> (+1.87%) 77.00 <8.00> (+12.00)
...m/google/cloud/spanner/connection/SpannerPool.java 86.88% <100.00%> (+0.77%) 31.00 <0.00> (ø)
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 81.85% <100.00%> (+0.29%) 81.00 <1.00> (+1.00)
.../admin/database/v1/stub/GrpcDatabaseAdminStub.java 97.79% <0.00%> (+0.49%) 31.00% <0.00%> (+1.00%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update facda8a...441b1aa. Read the comment docs.

…i/v1/GapicSpannerRpc.java

Co-authored-by: Thiago Nunes <thiagotnunes@google.com>
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 61ea2b9 into master Feb 1, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the reduce-wait-time-backend-exhausted-test branch February 1, 2021 10:06
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 1, 2021
thiagotnunes pushed a commit that referenced this pull request May 6, 2021
The BackendExhaustedTest deliberately causes requests to get stuck on the mock server. This causes the Spanner instance to refuse to shutdown nicely and causes it to wait for 10 seconds. This can be circumvented by using shutdownNow() to force the closure of all gRPC transport channels. This reduces the overall build time with approx 10 seconds.
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#5030

Changes:

build: upgrade Java microgenerator to v2.2.1
  # v2.2.1

  ## Bug Fixes
  - gax batching regression (googleapis#863) (3a6f168)

  # v2.2.0

  ## Features
  - Add REST AIP-151 LRO suport (cb1b534)
  - enable self signed JWT for http (googleapis#850) (aba0ec0)
  - Implement DIREGAPIC LRO annotations (googleapis#832) (d7b29e0)
  - REGAPIC initial implementation (googleapis#824) (fdcfe70)
  - REGAPIC Multitransport implementation (grpc+rest) (googleapis#833) (445daf4)

  ## Bug Fixes
  - [bazel] fix rest transport handling in assembly rule (googleapis#835) (92f7c1c)
  - DIREGAPIC LRO generated tests logic (googleapis#838) (8ae8e6f)
  - fix diregapic-lro logic (googleapis#834) (957f69a)

  PiperOrigin-RevId: 405492216
  Source-Link: googleapis/googleapis@4381242

docs: clarified meaning of the legacy editions docs: clarified semantic of the streaming APIs
  PiperOrigin-RevId: 405426307
  Source-Link: googleapis/googleapis@a51c341

docs: fix docstring formatting
  Committer: @parthea
  PiperOrigin-RevId: 405015203
  Source-Link: googleapis/googleapis@974ad5b
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
…2.0 (googleapis#835)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `25.1.0` -> `25.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/compatibility-slim/25.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/confidence-slim/25.1.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner-jdbc).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants