fix: Requester pays to check reason and fallback to error message validation #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
frankyn
requested changes
Mar 3, 2022
...d-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProvider.java
Outdated
Show resolved
Hide resolved
4 tasks
|
@sydney-munro Should the requester pays tests disabled in #825 be re-enabled here to ensure that they pass with this patch? |
yes. Those have been added back plus an additional test. |
BenWhitehead
approved these changes
Mar 4, 2022
sydney-munro
commented
Mar 4, 2022
| @@ -338,18 +327,20 @@ public void testAutodetectWhenNotRequesterPays() throws IOException { | |||
| ""); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testAutoDetectNoUserProject() throws IOException { | |||
| CloudStorageFileSystem testBucket = getRequesterPaysBucket(false, ""); | |||
There was a problem hiding this comment.
To avoid dealing with this check, we set autodetect to false and then just check the provider value for requesterPays directly.
frankyn
approved these changes
Mar 4, 2022
lbergelson
added a commit
to lbergelson/java-storage-nio
that referenced
this pull request
Mar 8, 2022
Fixes a NullPointerException introduced in googleapis#841 which occured when trying to check the the requesterPays status of a file while authenticated with an invalid service account. Refs: googleapis#849, googleapis#841
4 tasks
cojenco
pushed a commit
that referenced
this pull request
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #824 ☕️
If you write sample code, please follow the samples format.