Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Archive storage class #4

Closed
tritone opened this issue Dec 20, 2019 · 0 comments · Fixed by #19
Closed

Add support for Archive storage class #4

tritone opened this issue Dec 20, 2019 · 0 comments · Fixed by #19
Assignees
@athakor
Labels
api: storage Issues related to the googleapis/java-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tritone
Copy link
Contributor

tritone commented Dec 20, 2019

Mirrors googleapis/google-cloud-java#6578 ; there is already an open PR at googleapis/google-cloud-java#6685 which should be re-created in this repo.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Dec 21, 2019
@athakor athakor self-assigned this Dec 23, 2019
@athakor athakor added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Dec 23, 2019
@athakor athakor mentioned this issue Dec 27, 2019
Merged
@tritone tritone mentioned this issue Dec 27, 2019
Closed
@kolea2 kolea2 closed this as completed in #19 Jan 6, 2020
@google-cloud-label-sync google-cloud-label-sync bot added the api: storage Issues related to the googleapis/java-storage API. label Jan 31, 2020
BenWhitehead added a commit that referenced this issue May 2, 2022
@BenWhitehead
# This is a combination of 6 commits.
2018f6b 
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

wip: first stab at trying to corral all {to,from}Pb methods from model classes

# This is the commit message #2:

wip: refactor all access of ApiaryConversions to use their intermediary `codec` method

# This is the commit message #2:

wip: add clirr rule to allow removing accidental public hmacKeyMetadata#toPb

# This is the commit message #2:

wip: add enum ApiaryConversions#Codecs

# This is the commit message #3:

wip: fix lifecycle rule tests

# This is the commit message #4:

wip: fix blob metadata encoding

# This is the commit message #5:

wip: replace Blob#fromPb and Bucket#fromPb with BlobInfo#asBlob and BucketInfo#asBucket

The old fromPb method were conflating creating an instance of an "Info" model with create an instance of an "Info" model and binding it together with a Storage instance.

Now, an instance of Info model can be decoded (where/whenever) and then turned into a Blob/Bucket as necessary.

# This is the commit message #6:

tersify conversions
@cmateo917 cmateo917 mentioned this issue Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athakor athakor

Labels
api: storage Issues related to the googleapis/java-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for archive storage class athakor/java-storage
3 participants
@tritone @yoshi-automation @athakor