Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Managed Folders samples #2562

Merged
merged 7 commits into from
Jun 4, 2024
Merged

docs: Managed Folders samples #2562

merged 7 commits into from
Jun 4, 2024

Conversation

sydney-munro
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented May 23, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels May 23, 2024
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners May 23, 2024 19:48
@sydney-munro sydney-munro added the owlbot:ignore instruct owl-bot to ignore a PR label May 23, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 3, 2024
@sydney-munro
linter
669d721 
update without managed folder name populated

lint

format bucketname

enable uniform bucket level access

moving config update

enabling uniform bucket level access

figure out why tests are failing

use format instead of

linter

fixing tests

finally fix test and add in other tests

linter

adding copyrights to tests

removing unnecessary changed to downloadbytesrangetest
BenWhitehead
BenWhitehead requested changes Jun 4, 2024
View reviewed changes
samples/snippets/src/main/java/com/example/storage/managedfolders/CreateManagedFolder.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/managedfolders/DeleteManagedFolder.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/managedfolders/GetManagedFolder.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/managedfolders/ListManagedFolders.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/managedfolders/CreateManagedFolder.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/managedfolders/DeleteManagedFolder.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/managedfolders/GetManagedFolder.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/managedfolders/ListManagedFolders.java Outdated Show resolved Hide resolved
sydney-munro and others added 3 commits June 4, 2024 12:58
@sydney-munro @BenWhitehead
Update samples/snippets/src/main/java/com/example/storage/managedfold…
efe3156 
…ers/CreateManagedFolder.java

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@sydney-munro @BenWhitehead
Apply suggestions from code review
f48bc54 
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@sydney-munro
pr comments
82b1ce7
BenWhitehead
BenWhitehead approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@sydney-munro
Copy link
Collaborator Author

/gcbrun

@sydney-munro sydney-munro merged commit 5ffc1f2 into main Jun 4, 2024
21 of 22 checks passed
@sydney-munro sydney-munro deleted the mf branch June 4, 2024 23:09
@release-please release-please bot mentioned this pull request Jun 4, 2024
Merged
@sydney-munro sydney-munro mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 6, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@sofisl sofisl mentioned this pull request Jun 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

Assignees

@minherz minherz

Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sydney-munro @BenWhitehead @minherz