fix: exclude messages field from Datastore index to avoid 1500 bytes limit #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
|
/gcbrun |
|
Hi @averikitsch, |
|
/gcbrun |
|
@JU-2094 is currently out of office and will review next week. Thanks! |
|
/gcbrun |
averikitsch
approved these changes
Apr 2, 2024
|
@cymarechal-devoteam can you resolve the merge conflicts? |
…astore-unindexed-fields
That should be it! Please let me know if there is anything else. |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
While playing around with DatastoreChatMessageHistory, I noticed that I quickly ran into Datastore's 1,500 bytes limit for indexed string property's UTF-8 encoding (source: https://cloud.google.com/datastore/docs/concepts/limits).
This PR creates a simple test case to demonstrate the issue and solves it by using Datastore's
exclude_from_indexesparameter.Feedback appreciated!