feat: accept apiEndpoint override #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
added
the
status: blocked
JustinBeckwith
added a commit
to googleapis/nodejs-common
that referenced
this pull request
May 23, 2019
BREAKING CHANGE: This adds the apiEndpoint property as a required field for the ServiceConfig, and makes it a public property on the Service class. This is being added to broadly support apiEndpoint overrides. See googleapis/nodejs-bigquery#455 to see how this would be used.
JustinBeckwith
removed
the
status: blocked
|
@bcoe @stephenplusplus this is ready for a real look. |
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 99.42% 99.42% +<.01%
==========================================
Files 5 5
Lines 699 700 +1
Branches 194 194
==========================================
+ Hits 695 696 +1
- Misses 2 3 +1
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
==========================================
+ Coverage 99.42% 99.42% +<.01%
==========================================
Files 5 5
Lines 699 700 +1
Branches 194 194
==========================================
+ Hits 695 696 +1
- Misses 2 3 +1
+ Partials 2 1 -1
Continue to review full report at Codecov.
|
1 task
callmehiphop
approved these changes
May 28, 2019
51 tasks
robertomartinez09515
added a commit
to robertomartinez09515/nodejs-common-create
that referenced
this pull request
Jul 25, 2022
BREAKING CHANGE: This adds the apiEndpoint property as a required field for the ServiceConfig, and makes it a public property on the Service class. This is being added to broadly support apiEndpoint overrides. See googleapis/nodejs-bigquery#455 to see how this would be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets developers provide an api endpoint to override the backend service Url.