feat!: add apiEndpoint property to service config #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
========================================
+ Coverage 98% 98% +<.01%
========================================
Files 5 5
Lines 401 402 +1
Branches 99 99
========================================
+ Hits 393 394 +1
Misses 3 3
Partials 5 5
Continue to review full report at Codecov.
|
callmehiphop
approved these changes
May 23, 2019
JustinBeckwith
changed the title
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This adds the
apiEndpointproperty as a required field for theServiceConfig, and makes it a public property on theServiceclass. This is being added to broadly supportapiEndpointoverrides.See googleapis/nodejs-bigquery#455 to see how this would be used.