Skip to content

Commit

Permalink
fix: Remove bigtable instances left over when system tests run (#1265)
Browse files Browse the repository at this point in the history
* Use the prefix from the common file for deleting

Instances are not currently being cleaned up by the reap instances function because a filter is not selecting instances based on the right prefix. It looks like this fix should solve the issue.

* fix: Use the prefix from the common file for deleting

Instances are not currently being cleaned up by the reap instances function because a filter is not selecting instances based on the right prefix. It looks like this fix should solve the issue.
  • Loading branch information
danieljbruce committed Apr 28, 2023
1 parent c80e9f6 commit 0526612
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions system-test/bigtable.ts
Expand Up @@ -25,9 +25,7 @@ import {Family} from '../src/family.js';
import {Row} from '../src/row.js';
import {Table} from '../src/table.js';
import {RawFilter} from '../src/filter';
import {generateId} from './common';

const PREFIX = 'gcloud-tests-';
import {generateId, PREFIX} from './common';

describe('Bigtable', () => {
const bigtable = new Bigtable();
Expand Down

0 comments on commit 0526612

Please sign in to comment.