refactor: enable tslint rules (#664)

samples/document-snippets/table.js

@@ -204,10 +204,10 @@ const snippets = {
       .on('error', err => {
         // Handle the error.
       })
-      .on('data', function(row) {
+      .on('data', row => {
         // `row` is a Row object.
       })
-      .on('end', function() {
+      .on('end', () => {
         // All rows retrieved.
       });
     //-

samples/test/app-profile.js

@@ -27,7 +27,7 @@ const appProfileSnippets = require('./app-profile.js');
 
 const instance = bigtable.instance(INSTANCE_ID);
 
-describe.skip('App Profile Snippets', function() {
+describe.skip('App Profile Snippets', () => {
   before(() => {
     instance.create({
       clusters: [

samples/test/instance.js

@@ -26,7 +26,7 @@ const TABLE_ID = `nodejs-bigtable-samples-${uuid.v4()}`.substr(0, 30); // Bigtab
 
 const instanceSnippets = require('./instance.js');
 
-describe.skip('Instance Snippets', function() {
+describe.skip('Instance Snippets', () => {
   after(async () => {
     try {
       const instance = await bigtable.instance(INSTANCE_ID);
@@ -47,7 +47,7 @@ describe.skip('Instance Snippets', function() {
   //   instanceSnippets.createCluster(INSTANCE_ID, CLUSTER_ID);
   // });
 
-  // it('should create an app-profile', function(done) {
+  // it('should create an app-profile', done => {
   //   instanceSnippets.createAppProfile(INSTANCE_ID, APP_PROFILE_ID, done);
   // });
 

samples/test/row.js

@@ -27,7 +27,7 @@ const rowSnippets = require('./row.js');
 
 const instance = bigtable.instance(INSTANCE_ID);
 
-describe.skip('Row Snippets', function() {
+describe.skip('Row Snippets', () => {
   before(async () => {
     try {
       await instance.create({

samples/test/table.js

@@ -27,7 +27,7 @@ const tableSnippets = require('./table.js');
 
 const instance = bigtable.instance(INSTANCE_ID);
 
-describe.skip('Table Snippets', function() {
+describe.skip('Table Snippets', () => {
   before(async () => {
     try {
       await instance.create({

samples/test/write.js

@@ -46,19 +46,19 @@ describe('writes', async () => {
     assert.match(stdout, /Successfully wrote row .*/);
   });
 
-  it('should do a conditional write', function() {
+  it('should do a conditional write', () => {
     const stdout = execSync(
       `node writeConditionally ${INSTANCE_ID} ${TABLE_ID}`
     );
     assert.match(stdout, /Successfully updated row's os_name/);
   });
 
-  it('should do an increment', function() {
+  it('should do an increment', () => {
     const stdout = execSync(`node writeIncrement ${INSTANCE_ID} ${TABLE_ID}`);
     assert.match(stdout, /Successfully updated row .*/);
   });
 
-  it('should do a batch write', function() {
+  it('should do a batch write', () => {
     const stdout = execSync(`node writeBatch ${INSTANCE_ID} ${TABLE_ID}`);
     assert.match(stdout, /Successfully wrote 2 rows: .*/);
   });

src/app-profile.ts

@@ -272,9 +272,9 @@ Please use the format 'my-app-profile' or '${instance.name}/appProfiles/my-app-p
     const options =
       typeof optionsOrCallback === 'object' ? optionsOrCallback : {};
 
-    const reqOpts: any = {
+    const reqOpts = {
       name: this.name,
-    };
+    } as google.bigtable.admin.v2.IDeleteAppProfileRequest;
 
     if (is.boolean(options.ignoreWarnings)) {
       reqOpts.ignoreWarnings = options.ignoreWarnings;
@@ -443,12 +443,12 @@ Please use the format 'my-app-profile' or '${instance.name}/appProfiles/my-app-p
       typeof optionsOrCallback === 'function' ? optionsOrCallback : cb!;
     const gaxOptions =
       typeof optionsOrCallback === 'object' ? optionsOrCallback : {};
-    const reqOpts: any = {
+    const reqOpts = {
       appProfile: AppProfile.formatAppProfile_(metadata as AppProfileOptions),
       updateMask: {
         paths: [],
       },
-    };
+    } as google.bigtable.admin.v2.IUpdateAppProfileRequest;
     reqOpts.appProfile!.name = this.name;
     const fieldsForMask = [
       'description',
@@ -457,8 +457,8 @@ Please use the format 'my-app-profile' or '${instance.name}/appProfiles/my-app-p
       'allowTransactionalWrites',
     ];
     fieldsForMask.forEach(field => {
-      if (reqOpts.appProfile[field]) {
-        reqOpts.updateMask.paths.push(snakeCase(field));
+      if (reqOpts.appProfile![field]) {
+        reqOpts.updateMask!.paths!.push(snakeCase(field));
       }
     });
 

src/chunktransformer.ts

@@ -65,11 +65,11 @@ class TransformError extends Error {
  * ROW_IN_PROGRESS: state after first valid chunk without commitRow or resetRow
  * CELL_IN_PROGRESS: state when valueSize > 0(partial cell)
  */
-export const RowStateEnum = Object.freeze({
-  NEW_ROW: 1,
-  ROW_IN_PROGRESS: 2,
-  CELL_IN_PROGRESS: 3,
-});
+export enum RowStateEnum {
+  NEW_ROW = 1,
+  ROW_IN_PROGRESS = 2,
+  CELL_IN_PROGRESS = 3,
+}
 
 /**
  * ChunkTransformer formats all incoming chunks in to row
@@ -143,6 +143,8 @@ export class ChunkTransformer extends Transform {
         case RowStateEnum.CELL_IN_PROGRESS:
           this.processCellInProgress(chunk);
           break;
+        default:
+          break;
       }
       if (this._destroyed) {
         return;

src/filter.ts

@@ -47,6 +47,7 @@ export interface Time {
   end: Date;
 }
 
+// tslint:disable-next-line no-any
 export type RawFilter = any;
 
 export interface Condition {
@@ -255,6 +256,7 @@ export class Filter {
       [index: string]: Function;
     }
     const filter = new Filter();
+    // tslint:disable-next-line no-any
     arrify(filters).forEach((filterObj: any) => {
       const key = Object.keys(filterObj)[0];
       if (typeof ((filter as {}) as Fn)[key] !== 'function') {
@@ -434,6 +436,7 @@ export class Filter {
     }
 
     if (col.start || col.end) {
+      // tslint:disable-next-line no-any
       const range: any = Filter.createRange(col.start!, col.end!, 'Qualifier');
 
       range.familyName = col.family;