feat: AuditConfig for IAM v1 (#1061)

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 439356405 Source-Link: googleapis/googleapis@afa2ba1 Source-Link: googleapis/googleapis-gen@3e40c17 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2U0MGMxN2UxNTEwYzk1ZmFiNThmYzIxNDNjY2I2MWNjZWNhNTk4OSJ9 docs: Update `cpu_utilization_percent` limit docs: Remove the limitation of all clusters in a CMEK instance must use the same key PiperOrigin-RevId: 438385300 Source-Link: googleapis/googleapis@c59f02e Source-Link: googleapis/googleapis-gen@04d03d1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDRkMDNkMTdhYWZhN2I0NDIyZjczYzkzNjAwZjA0MDU0MjgxN2ZjZCJ9
googleapis · Apr 5, 2022 · d1b5f1a · d1b5f1a
1 parent 6c09b0a
commit d1b5f1a
Show file tree

Hide file tree

Showing 8 changed files with 42 additions and 8 deletions.
diff --git a/protos/google/bigtable/admin/v2/instance.proto b/protos/google/bigtable/admin/v2/instance.proto
@@ -118,7 +118,8 @@ message Instance {
 message AutoscalingTargets {
   // The cpu utilization that the Autoscaler should be trying to achieve.
   // This number is on a scale from 0 (no utilization) to
-  // 100 (total utilization).
+  // 100 (total utilization), and is limited between 10 and 80, otherwise it
+  // will return INVALID_ARGUMENT error.
   int32 cpu_utilization_percent = 2;
 }
 
@@ -165,7 +166,6 @@ message Cluster {
     //  `cloudkms.cryptoKeyEncrypterDecrypter` role on the CMEK key.
     //  2) Only regional keys can be used and the region of the CMEK key must
     //  match the region of the cluster.
-    // 3) All clusters within an instance must use the same CMEK key.
     string kms_key_name = 1 [(google.api.resource_reference) = {
       type: "cloudkms.googleapis.com/CryptoKey"
     }];

diff --git a/samples/generated/v2/bigtable_instance_admin.get_iam_policy.js b/samples/generated/v2/bigtable_instance_admin.get_iam_policy.js
@@ -32,7 +32,7 @@ function main(resource) {
   // const resource = 'abc123'
   /**
    *  OPTIONAL: A `GetPolicyOptions` object for specifying options to
-   *  `GetIamPolicy`. This field is only used by Cloud IAM.
+   *  `GetIamPolicy`.
    */
   // const options = {}
 

diff --git a/samples/generated/v2/bigtable_instance_admin.set_iam_policy.js b/samples/generated/v2/bigtable_instance_admin.set_iam_policy.js
@@ -37,6 +37,13 @@ function main(resource, policy) {
    *  might reject them.
    */
   // const policy = {}
+  /**
+   *  OPTIONAL: A FieldMask specifying which fields of the policy to modify. Only
+   *  the fields in the mask will be modified. If no mask is provided, the
+   *  following default mask is used:
+   *  `paths: "bindings, etag"`
+   */
+  // const updateMask = {}
 
   // Imports the Admin library
   const {BigtableInstanceAdminClient} = require('@google-cloud/bigtable').v2;

diff --git a/samples/generated/v2/bigtable_table_admin.get_iam_policy.js b/samples/generated/v2/bigtable_table_admin.get_iam_policy.js
@@ -32,7 +32,7 @@ function main(resource) {
   // const resource = 'abc123'
   /**
    *  OPTIONAL: A `GetPolicyOptions` object for specifying options to
-   *  `GetIamPolicy`. This field is only used by Cloud IAM.
+   *  `GetIamPolicy`.
    */
   // const options = {}
 

diff --git a/samples/generated/v2/bigtable_table_admin.set_iam_policy.js b/samples/generated/v2/bigtable_table_admin.set_iam_policy.js
@@ -37,6 +37,13 @@ function main(resource, policy) {
    *  might reject them.
    */
   // const policy = {}
+  /**
+   *  OPTIONAL: A FieldMask specifying which fields of the policy to modify. Only
+   *  the fields in the mask will be modified. If no mask is provided, the
+   *  following default mask is used:
+   *  `paths: "bindings, etag"`
+   */
+  // const updateMask = {}
 
   // Imports the Admin library
   const {BigtableTableAdminClient} = require('@google-cloud/bigtable').v2;

diff --git a/samples/generated/v2/snippet_metadata.google.bigtable.admin.v2.json b/samples/generated/v2/snippet_metadata.google.bigtable.admin.v2.json
@@ -858,7 +858,7 @@
       "segments": [
         {
           "start": 25,
-          "end": 59,
+          "end": 66,
           "type": "FULL"
         }
       ],
@@ -874,6 +874,10 @@
           {
             "name": "policy",
             "type": ".google.iam.v1.Policy"
+          },
+          {
+            "name": "update_mask",
+            "type": ".google.protobuf.FieldMask"
           }
         ],
         "resultType": ".google.iam.v1.Policy",
@@ -1918,7 +1922,7 @@
       "segments": [
         {
           "start": 25,
-          "end": 59,
+          "end": 66,
           "type": "FULL"
         }
       ],
@@ -1934,6 +1938,10 @@
           {
             "name": "policy",
             "type": ".google.iam.v1.Policy"
+          },
+          {
+            "name": "update_mask",
+            "type": ".google.protobuf.FieldMask"
           }
         ],
         "resultType": ".google.iam.v1.Policy",

diff --git a/src/v2/bigtable_instance_admin_client.ts b/src/v2/bigtable_instance_admin_client.ts
@@ -1383,7 +1383,7 @@ export class BigtableInstanceAdminClient {
    *   See the operation documentation for the appropriate value for this field.
    * @param {google.iam.v1.GetPolicyOptions} request.options
    *   OPTIONAL: A `GetPolicyOptions` object for specifying options to
-   *   `GetIamPolicy`. This field is only used by Cloud IAM.
+   *   `GetIamPolicy`.
    * @param {object} [options]
    *   Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
    * @returns {Promise} - The promise which resolves to an array.
@@ -1474,6 +1474,12 @@ export class BigtableInstanceAdminClient {
    *   the policy is limited to a few 10s of KB. An empty policy is a
    *   valid policy but certain Cloud Platform services (such as Projects)
    *   might reject them.
+   * @param {google.protobuf.FieldMask} request.updateMask
+   *   OPTIONAL: A FieldMask specifying which fields of the policy to modify. Only
+   *   the fields in the mask will be modified. If no mask is provided, the
+   *   following default mask is used:
+   *
+   *   `paths: "bindings, etag"`
    * @param {object} [options]
    *   Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
    * @returns {Promise} - The promise which resolves to an array.

diff --git a/src/v2/bigtable_table_admin_client.ts b/src/v2/bigtable_table_admin_client.ts
@@ -1590,7 +1590,7 @@ export class BigtableTableAdminClient {
    *   See the operation documentation for the appropriate value for this field.
    * @param {google.iam.v1.GetPolicyOptions} request.options
    *   OPTIONAL: A `GetPolicyOptions` object for specifying options to
-   *   `GetIamPolicy`. This field is only used by Cloud IAM.
+   *   `GetIamPolicy`.
    * @param {object} [options]
    *   Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
    * @returns {Promise} - The promise which resolves to an array.
@@ -1681,6 +1681,12 @@ export class BigtableTableAdminClient {
    *   the policy is limited to a few 10s of KB. An empty policy is a
    *   valid policy but certain Cloud Platform services (such as Projects)
    *   might reject them.
+   * @param {google.protobuf.FieldMask} request.updateMask
+   *   OPTIONAL: A FieldMask specifying which fields of the policy to modify. Only
+   *   the fields in the mask will be modified. If no mask is provided, the
+   *   following default mask is used:
+   *
+   *   `paths: "bindings, etag"`
    * @param {object} [options]
    *   Call options. See {@link https://googleapis.dev/nodejs/google-gax/latest/interfaces/CallOptions.html|CallOptions} for more details.
    * @returns {Promise} - The promise which resolves to an array.