Skip to content

Commit

Permalink
fix: improve retry logic for streaming API calls (#1372)
Browse files Browse the repository at this point in the history
* feat: Modify ModifyColumnFamiliesRequest proto to expose ignore_warnings field

PiperOrigin-RevId: 590940407

Source-Link: googleapis/googleapis@fb027c8

Source-Link: googleapis/googleapis-gen@f0728cd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjA3MjhjZGEyMjdiMzg4MzU4MjJjNGU1NTE5ZTU2OGNlOGQyYjVhYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Adding feature flags for routing cookie and retry info

PiperOrigin-RevId: 591912877

Source-Link: googleapis/googleapis@f6505fe

Source-Link: googleapis/googleapis-gen@7499187
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzQ5OTE4NzQxNWY4ZDQwNWVmMGQ0NmRkNmZmNjA4YjEyNWM1M2M4ZiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: update comment for `AccountVerificationInfo.username`

PiperOrigin-RevId: 598888823

Source-Link: googleapis/googleapis@955ff0a

Source-Link: googleapis/googleapis-gen@8b0b992
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGIwYjk5MmNkY2EwMDQxOWNkZjQ0MzNkNmJiZTNjZjNlOTNmMWRkNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: configure PHP client to generate new surface

PiperOrigin-RevId: 599228576

Source-Link: googleapis/googleapis@ef54eaf

Source-Link: googleapis/googleapis-gen@4d0d81b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGQwZDgxYjc4MjJlMmYzNjFkZTZkNmUwMWIzNzVjY2M5YWYzZTEwOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: improve retry logic for streaming API calls
build: update typescript generator version to 4.3.0

The streaming API call retry logic has changed, which in some rare cases may require code changes. Please feel free to reach out to us in the issues if you experience new problems with retrying streaming calls after this update.

PiperOrigin-RevId: 599622271

Source-Link: googleapis/googleapis@6239c21

Source-Link: googleapis/googleapis-gen@da13d82
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGExM2Q4MjIyZDNiYTMzNzM0NTAxOTk5ODY0NDU4NjQwZjE0MDVhZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Make a copy of the gaxOpts parameter

Don’t modify the gaxOptions parameter in place and pass it down. This change makes it so that changes to gax options downstream will not affect gaxOptions in this layer of the call stack which is desirable and which also allows the failing test to pass.

* Revert "Make a copy of the gaxOpts parameter"

This reverts commit aa0c46b.

* Revert "Revert "Make a copy of the gaxOpts parameter"" (#1379)

This reverts commit 3cadbe0.

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Bruce <djbruce@google.com>
Co-authored-by: danieljbruce <danieljbruce@users.noreply.github.com>
  • Loading branch information
4 people committed Jan 23, 2024
1 parent 8cc17aa commit e8083a4
Show file tree
Hide file tree
Showing 72 changed files with 1,529 additions and 262 deletions.
4 changes: 2 additions & 2 deletions .jsdoc.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2023 Google LLC
// Copyright 2024 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -40,7 +40,7 @@ module.exports = {
includePattern: '\\.js$'
},
templates: {
copyright: 'Copyright 2023 Google LLC',
copyright: 'Copyright 2024 Google LLC',
includeDate: false,
sourceFiles: false,
systemName: '@google-cloud/bigtable',
Expand Down
3 changes: 3 additions & 0 deletions protos/google/bigtable/admin/v2/bigtable_table_admin.proto
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,9 @@ message ModifyColumnFamiliesRequest {
// family, for example).
repeated Modification modifications = 2
[(google.api.field_behavior) = REQUIRED];

// Optional. If true, ignore safety checks when modifying the column families.
bool ignore_warnings = 3 [(google.api.field_behavior) = OPTIONAL];
}

// Request message for
Expand Down
8 changes: 8 additions & 0 deletions protos/google/bigtable/v2/feature_flags.proto
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,12 @@ message FeatureFlags {
// Notify the server that the client supports the last_scanned_row field
// in ReadRowsResponse for long-running scans.
bool last_scanned_row_responses = 4;

// Notify the server that the client supports using encoded routing cookie
// strings to retry requests with.
bool routing_cookie = 6;

// Notify the server that the client supports using retry info back off
// durations to retry requests with.
bool retry_info = 7;
}
Loading

0 comments on commit e8083a4

Please sign in to comment.