fix: manual generate library for ongoing stream on closed client #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summer-ji-eng
requested review from
alexander-fenster,
mutianf and
igorbernstein2
product-auto-label
bot
added
the
api: bigtable
|
Warning: This pull request is touching the following templated files:
|
mutianf
approved these changes
Feb 3, 2022
summer-ji-eng
commented
Feb 3, 2022
| { | ||
| "clientLibrary": { | ||
| "name": "nodejs-bigtable", | ||
| "version": "0.1.0", |
There was a problem hiding this comment.
@sofisl could you take a look? Is the version right to you?
There was a problem hiding this comment.
This should be the current version of the library, but there's no way to put that information into the generator. I think, for now, we should just change it manually, but then have release-please update this value when a new release is made. I'll open a bug on release-please.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
🤖 I have created a release *beep* *boop* --- ### [3.9.2](v3.9.1...v3.9.2) (2022-02-03) ### Bug Fixes * manual generate library for ongoing stream on closed client ([#1011](#1011)) ([b6fec4c](b6fec4c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual update generator v2.13.0.