-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Group key and encryption encoding into one function #1095
Open
danieljbruce
wants to merge
16
commits into
googleapis:main
Choose a base branch
from
danieljbruce:autoscaler-refactor-other-params
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Group key and encryption encoding into one function #1095
danieljbruce
wants to merge
16
commits into
googleapis:main
from
danieljbruce:autoscaler-refactor-other-params
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Pull request size is large.
api: bigtable
Issues related to the googleapis/nodejs-bigtable API.
labels
Jun 2, 2022
danieljbruce
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 2, 2022
danieljbruce
added
owlbot:run
Add this label to trigger the Owlbot post processor.
and removed
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Aug 23, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 23, 2022
danieljbruce
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 23, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/nodejs-bigtable API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is dependent on #1093. This PR is the 4th of a series of PRs for refactoring the conversion of cluster input parameters
key
andencryption
into one function so that we don't have repeated code. Still more needs to be done like we should do the same for the storage parameter and we should also think about doing these conversions for cluster updates as well though breaking changes are involved with such tasks so those changes should be considered carefully.