Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try new version of google-gax #1362

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Try new version of google-gax #1362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
536b26d
Try new version of google-gax
danieljbruce Nov 13, 2023
6287c99
Add console.time messages
danieljbruce Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file added google-gax.tgz
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"dot-prop": "^6.0.0",
"escape-string-regexp": "^4.0.0",
"extend": "^3.0.2",
"google-gax": "^4.0.3",
"google-gax": "./google-gax.tgz",
"grpc-gcp": "^1.0.1",
"is": "^3.0.1",
"is-utf8": "^0.2.1",
Expand Down
15 changes: 10 additions & 5 deletions src/v2/bigtable_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,24 +189,29 @@ export class BigtableClient {
this.descriptors.stream = {
readRows: new this._gaxModule.StreamDescriptor(
this._gaxModule.StreamType.SERVER_STREAMING,
opts.fallback === 'rest'
opts.fallback === 'rest',
true
),
sampleRowKeys: new this._gaxModule.StreamDescriptor(
this._gaxModule.StreamType.SERVER_STREAMING,
opts.fallback === 'rest'
opts.fallback === 'rest',
true
),
mutateRows: new this._gaxModule.StreamDescriptor(
this._gaxModule.StreamType.SERVER_STREAMING,
opts.fallback === 'rest'
opts.fallback === 'rest',
true
),
generateInitialChangeStreamPartitions:
new this._gaxModule.StreamDescriptor(
this._gaxModule.StreamType.SERVER_STREAMING,
opts.fallback === 'rest'
opts.fallback === 'rest',
true
),
readChangeStream: new this._gaxModule.StreamDescriptor(
this._gaxModule.StreamType.SERVER_STREAMING,
opts.fallback === 'rest'
opts.fallback === 'rest',
true
),
};

Expand Down
3 changes: 3 additions & 0 deletions testproxy/services/read-rows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ const readRows = ({clientMap}) =>
const table = getTableInfo(bigtable, tableName);
const rowsOptions = getRowsOptions(readRowsRequest);
try {
console.log('getRows call');
console.time('making getRows call');
const [rows] = await table.getRows(rowsOptions);
console.timeEnd('making getRows call');
return {
status: {code: grpc.status.OK, details: []},
rows: rows.map(getRowResponse),
Expand Down