Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extend timeouts for deleting snapshots, backups and tables #1387

Merged
merged 4 commits into from
Feb 12, 2024
Merged

fix: extend timeouts for deleting snapshots, backups and tables #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
769caac
build: update gapic-generator-typescript to v4.4.1
gcf-owl-bot[bot] Feb 7, 2024
1513059
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 7, 2024
41fbb9b
fix: extend timeouts for deleting snapshots, backups and tables
gcf-owl-bot[bot] Feb 8, 2024
318188c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions src/v2/bigtable_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ export class BigtableClient {

/**
* The DNS address for this API service.
* @deprecated
* @deprecated Use the apiEndpoint method of the client instance.
* @returns {string} The DNS address for this service.
*/
static get servicePath() {
Expand All @@ -349,9 +349,8 @@ export class BigtableClient {
}

/**
* The DNS address for this API service - same as servicePath,
* exists for compatibility reasons.
* @deprecated
* The DNS address for this API service - same as servicePath.
* @deprecated Use the apiEndpoint method of the client instance.
* @returns {string} The DNS address for this service.
*/
static get apiEndpoint() {
Expand All @@ -371,14 +370,6 @@ export class BigtableClient {
* The DNS address for this API service.
* @returns {string} The DNS address for this service.
*/
get servicePath() {
return this._servicePath;
}

/**
* The DNS address for this API service - same as servicePath().
* @returns {string} The DNS address for this service.
*/
get apiEndpoint() {
return this._servicePath;
}
Expand Down
15 changes: 3 additions & 12 deletions src/v2/bigtable_instance_admin_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ export class BigtableInstanceAdminClient {

/**
* The DNS address for this API service.
* @deprecated
* @deprecated Use the apiEndpoint method of the client instance.
* @returns {string} The DNS address for this service.
*/
static get servicePath() {
Expand All @@ -467,9 +467,8 @@ export class BigtableInstanceAdminClient {
}

/**
* The DNS address for this API service - same as servicePath,
* exists for compatibility reasons.
* @deprecated
* The DNS address for this API service - same as servicePath.
* @deprecated Use the apiEndpoint method of the client instance.
* @returns {string} The DNS address for this service.
*/
static get apiEndpoint() {
Expand All @@ -489,14 +488,6 @@ export class BigtableInstanceAdminClient {
* The DNS address for this API service.
* @returns {string} The DNS address for this service.
*/
get servicePath() {
return this._servicePath;
}

/**
* The DNS address for this API service - same as servicePath().
* @returns {string} The DNS address for this service.
*/
get apiEndpoint() {
return this._servicePath;
}
Expand Down
15 changes: 3 additions & 12 deletions src/v2/bigtable_table_admin_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ export class BigtableTableAdminClient {

/**
* The DNS address for this API service.
* @deprecated
* @deprecated Use the apiEndpoint method of the client instance.
* @returns {string} The DNS address for this service.
*/
static get servicePath() {
Expand All @@ -487,9 +487,8 @@ export class BigtableTableAdminClient {
}

/**
* The DNS address for this API service - same as servicePath,
* exists for compatibility reasons.
* @deprecated
* The DNS address for this API service - same as servicePath.
* @deprecated Use the apiEndpoint method of the client instance.
* @returns {string} The DNS address for this service.
*/
static get apiEndpoint() {
Expand All @@ -509,14 +508,6 @@ export class BigtableTableAdminClient {
* The DNS address for this API service.
* @returns {string} The DNS address for this service.
*/
get servicePath() {
return this._servicePath;
}

/**
* The DNS address for this API service - same as servicePath().
* @returns {string} The DNS address for this service.
*/
get apiEndpoint() {
return this._servicePath;
}
Expand Down
6 changes: 3 additions & 3 deletions src/v2/bigtable_table_admin_client_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"retry_params_name": "default"
},
"DeleteTable": {
"timeout_millis": 60000,
"timeout_millis": 300000,
"retry_codes_name": "non_idempotent",
"retry_params_name": "default"
},
Expand Down Expand Up @@ -96,7 +96,7 @@
"retry_params_name": "264268458a9e88347dbacbd9398202ff5885a40b"
},
"DeleteSnapshot": {
"timeout_millis": 60000,
"timeout_millis": 300000,
"retry_codes_name": "non_idempotent",
"retry_params_name": "default"
},
Expand All @@ -116,7 +116,7 @@
"retry_params_name": "default"
},
"DeleteBackup": {
"timeout_millis": 60000,
"timeout_millis": 300000,
"retry_codes_name": "non_idempotent",
"retry_params_name": "default"
},
Expand Down
15 changes: 4 additions & 11 deletions test/gapic_bigtable_instance_admin_v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,6 @@ function stubAsyncIterationCall<ResponseType>(

describe('v2.BigtableInstanceAdminClient', () => {
describe('Common methods', () => {
it('has servicePath', () => {
const client =
new bigtableinstanceadminModule.v2.BigtableInstanceAdminClient();
const servicePath = client.servicePath;
assert.strictEqual(servicePath, 'bigtableadmin.googleapis.com');
});

it('has apiEndpoint', () => {
const client =
new bigtableinstanceadminModule.v2.BigtableInstanceAdminClient();
Expand Down Expand Up @@ -206,21 +199,21 @@ describe('v2.BigtableInstanceAdminClient', () => {
stub.restore();
});
}
it('sets servicePath according to universe domain camelCase', () => {
it('sets apiEndpoint according to universe domain camelCase', () => {
const client =
new bigtableinstanceadminModule.v2.BigtableInstanceAdminClient({
universeDomain: 'example.com',
});
const servicePath = client.servicePath;
const servicePath = client.apiEndpoint;
assert.strictEqual(servicePath, 'bigtableadmin.example.com');
});

it('sets servicePath according to universe domain snakeCase', () => {
it('sets apiEndpoint according to universe domain snakeCase', () => {
const client =
new bigtableinstanceadminModule.v2.BigtableInstanceAdminClient({
universe_domain: 'example.com',
});
const servicePath = client.servicePath;
const servicePath = client.apiEndpoint;
assert.strictEqual(servicePath, 'bigtableadmin.example.com');
});
it('does not allow setting both universeDomain and universe_domain', () => {
Expand Down
14 changes: 4 additions & 10 deletions test/gapic_bigtable_table_admin_v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,6 @@ function stubAsyncIterationCall<ResponseType>(

describe('v2.BigtableTableAdminClient', () => {
describe('Common methods', () => {
it('has servicePath', () => {
const client = new bigtabletableadminModule.v2.BigtableTableAdminClient();
const servicePath = client.servicePath;
assert.strictEqual(servicePath, 'bigtableadmin.googleapis.com');
});

it('has apiEndpoint', () => {
const client = new bigtabletableadminModule.v2.BigtableTableAdminClient();
const apiEndpoint = client.apiEndpoint;
Expand Down Expand Up @@ -201,19 +195,19 @@ describe('v2.BigtableTableAdminClient', () => {
stub.restore();
});
}
it('sets servicePath according to universe domain camelCase', () => {
it('sets apiEndpoint according to universe domain camelCase', () => {
const client = new bigtabletableadminModule.v2.BigtableTableAdminClient({
universeDomain: 'example.com',
});
const servicePath = client.servicePath;
const servicePath = client.apiEndpoint;
assert.strictEqual(servicePath, 'bigtableadmin.example.com');
});

it('sets servicePath according to universe domain snakeCase', () => {
it('sets apiEndpoint according to universe domain snakeCase', () => {
const client = new bigtabletableadminModule.v2.BigtableTableAdminClient({
universe_domain: 'example.com',
});
const servicePath = client.servicePath;
const servicePath = client.apiEndpoint;
assert.strictEqual(servicePath, 'bigtableadmin.example.com');
});
it('does not allow setting both universeDomain and universe_domain', () => {
Expand Down
14 changes: 4 additions & 10 deletions test/gapic_bigtable_v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,6 @@ function stubServerStreamingCall<ResponseType>(

describe('v2.BigtableClient', () => {
describe('Common methods', () => {
it('has servicePath', () => {
const client = new bigtableModule.v2.BigtableClient();
const servicePath = client.servicePath;
assert.strictEqual(servicePath, 'bigtable.googleapis.com');
});

it('has apiEndpoint', () => {
const client = new bigtableModule.v2.BigtableClient();
const apiEndpoint = client.apiEndpoint;
Expand Down Expand Up @@ -127,19 +121,19 @@ describe('v2.BigtableClient', () => {
stub.restore();
});
}
it('sets servicePath according to universe domain camelCase', () => {
it('sets apiEndpoint according to universe domain camelCase', () => {
const client = new bigtableModule.v2.BigtableClient({
universeDomain: 'example.com',
});
const servicePath = client.servicePath;
const servicePath = client.apiEndpoint;
assert.strictEqual(servicePath, 'bigtable.example.com');
});

it('sets servicePath according to universe domain snakeCase', () => {
it('sets apiEndpoint according to universe domain snakeCase', () => {
const client = new bigtableModule.v2.BigtableClient({
universe_domain: 'example.com',
});
const servicePath = client.servicePath;
const servicePath = client.apiEndpoint;
assert.strictEqual(servicePath, 'bigtable.example.com');
});
it('does not allow setting both universeDomain and universe_domain', () => {
Expand Down
Loading