Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rewrite createreadstream tests #1401

Closed
wants to merge 15 commits into from
Closed

test: rewrite createreadstream tests #1401

wants to merge 15 commits into from

Commits on Apr 11, 2024

  1. set up the test frame

    @danieljbruce
    danieljbruce committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    1b1947a View commit details
    Browse the repository at this point in the history

  2. Test is set up to evaluate streaming behavior

    @danieljbruce
    danieljbruce committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    59b2c26 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Modify test with the mock server to pass first tst

    @danieljbruce
    danieljbruce committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    baa5d8f View commit details
    Browse the repository at this point in the history

  2. Fix tests that are appending startKey and endKey

    @danieljbruce
    danieljbruce committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    869d5ce View commit details
    Browse the repository at this point in the history

  3. Getting all the tests working 

    - Transform the rowsLimit parameter into an integer
- Change the hook into a before hook so that we don’t attempt to create multiple mock servers
- Create a guard so that the stream only writes if there are row keys to write
    @danieljbruce
    danieljbruce committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5e69834 View commit details
    Browse the repository at this point in the history

  4. eliminate old createreadstream test 

    define new interfaces too
    @danieljbruce
    danieljbruce committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    bf29061 View commit details
    Browse the repository at this point in the history

  5. Remove only. rowsLimit should be optional

    @danieljbruce
    danieljbruce committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ad36097 View commit details
    Browse the repository at this point in the history

  6. Make rowKeysRead type more specific

    @danieljbruce
    danieljbruce committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2c57e61 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Add after hook to shut down server

    @danieljbruce
    danieljbruce committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    95b9463 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. First PR correction - remove any

    @danieljbruce
    danieljbruce committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    23919c5 View commit details
    Browse the repository at this point in the history

  2. Get rid of another any

    @danieljbruce
    danieljbruce committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    abcf0fc View commit details
    Browse the repository at this point in the history

  3. Get rid of the any suppressed by typescript 

    It was necessary to add guards to make this work. Also changed the error type to Google error.
    @danieljbruce
    danieljbruce committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    07ec565 View commit details
    Browse the repository at this point in the history

  4. Should use CreateReadStreamRequest as the type

    @danieljbruce
    danieljbruce committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    85a0317 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Remove the comment disabling linting on any

    @danieljbruce
    danieljbruce committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    286e782 View commit details
    Browse the repository at this point in the history

  2. Remove the import. It is not used anymore.

    @danieljbruce
    danieljbruce committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    f4136c1 View commit details
    Browse the repository at this point in the history