Createreadstream with mock server debugging 2 #1406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Transform the rowsLimit parameter into an integer - Change the hook into a before hook so that we don’t attempt to create multiple mock servers - Create a guard so that the stream only writes if there are row keys to write
define new interfaces too
product-auto-label
bot
added
size: s
|
The extra write prevents gax from retrying for some reason https://github.com/danieljbruce/nodejs-bigtable/tree/readrows-gapic-layer-with-mock-server-empty-write. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains the console log statements used for debugging interactions between createreadstream, gax and the mock server.
When cloning this branch, move
node_modules_copytonode_modulesto get all the console log statements in the dependencies. To see the changes withoutnode_modules_copyI suggest looking at the diff between this andcreatereadstream-with-mock-server.