Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example region-tags for app-profile object #288

Merged
merged 6 commits into from Dec 6, 2018
Merged

Added example region-tags for app-profile object #288

merged 6 commits into from Dec 6, 2018

Conversation

vijay-qlogic
Copy link
Contributor

Fixes #157 partially for app-profile object (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2018
@codecov
Copy link

codecov bot commented Aug 29, 2018 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@df82c10). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #288   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     10           
  Lines             ?   1269           
  Branches          ?      0           
=======================================
  Hits              ?   1269           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/app-profile.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df82c10...2ef1636. Read the comment docs.

@vijay-qlogic vijay-qlogic force-pushed the tag-ex-comments-app-profile branch 2 times, most recently from f90f300 to f8fde9c Compare September 5, 2018 18:00
@ghost ghost assigned sduskis Sep 21, 2018
@sduskis sduskis self-requested a review October 5, 2018 15:10
sduskis
sduskis suggested changes Nov 7, 2018
View reviewed changes
samples/document-snippets/app-profile.js Outdated
const appProfile = instance.appProfile(appProfileId);

appProfile
.create()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@sduskis
Copy link
Contributor

sduskis commented Nov 15, 2018

@vijay-qlogic, can you please fix the create() logic? @AVaksman, FYI

@JustinBeckwith
Copy link
Contributor

@vijay-qlogic @sduskis this PR is getting a little moldy. Can we close this out? Is there more work to be done here?

1 similar comment
@JustinBeckwith
Copy link
Contributor

@vijay-qlogic @sduskis this PR is getting a little moldy. Can we close this out? Is there more work to be done here?

@sduskis
Copy link
Contributor

sduskis commented Dec 6, 2018

@JustinBeckwith, it looks like @vijay-qlogic addressed my comments. I'm going to approve.

@sduskis sduskis merged commit dd4701a into googleapis:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

Assignees

@sduskis sduskis

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vijay-qlogic @sduskis @JustinBeckwith @googlebot