Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix number decoding #77

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Fix number decoding #77

merged 2 commits into from
Apr 10, 2018

Conversation

pkriete
Copy link
Contributor

@pkriete pkriete commented Apr 4, 2018 •
edited

Fixes #76

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [ ] Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2018
@codecov
Copy link

codecov bot commented Apr 4, 2018 •
edited

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #77   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1201   1201           
=====================================
  Hits         1201   1201
Impacted Files Coverage Δ
src/chunktransformer.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09329e...90a257a. Read the comment docs.

@pkriete pkriete mentioned this pull request Apr 4, 2018
Closed
@ghost ghost assigned kolodny Apr 10, 2018
kolodny
kolodny approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@kolodny kolodny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR!

@kolodny kolodny merged commit 44893c9 into googleapis:master Apr 10, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2018
@sduskis sduskis mentioned this pull request Apr 12, 2018
Closed
@rlucioni rlucioni mentioned this pull request Apr 20, 2018
Closed
@stephenplusplus stephenplusplus mentioned this pull request Apr 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolodny kolodny kolodny approved these changes

Assignees

@kolodny kolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pkriete @kolodny @googlebot