Skip to content

Commit

Permalink
build!: update library to use Node 12 (#749)
Browse files Browse the repository at this point in the history
* feat!: Update library to use Node 12

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
alexander-fenster and gcf-owl-bot[bot] committed May 17, 2022
1 parent 88bde38 commit 3d5acce
Show file tree
Hide file tree
Showing 15 changed files with 8 additions and 145 deletions.
2 changes: 1 addition & 1 deletion .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ branchProtectionRules:
- "ci/kokoro: System test"
- docs
- lint
- test (10)
- test (12)
- test (14)
- test (16)
- cla/google
- windows
- OwlBot Post Processor
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [10, 12, 14]
node: [12, 14, 16]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
34 changes: 0 additions & 34 deletions .kokoro/continuous/node10/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/continuous/node10/docs.cfg

This file was deleted.

9 changes: 0 additions & 9 deletions .kokoro/continuous/node10/test.cfg

This file was deleted.

24 changes: 0 additions & 24 deletions .kokoro/continuous/node8/common.cfg

This file was deleted.

Empty file removed .kokoro/continuous/node8/test.cfg
Empty file.
34 changes: 0 additions & 34 deletions .kokoro/presubmit/node10/common.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/presubmit/node10/docs.cfg

This file was deleted.

4 changes: 0 additions & 4 deletions .kokoro/presubmit/node10/lint.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node10/test.cfg
Empty file.
24 changes: 0 additions & 24 deletions .kokoro/presubmit/node8/common.cfg

This file was deleted.

Empty file removed .kokoro/presubmit/node8/test.cfg
Empty file.
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"author": "Google Inc.",
"engines": {
"node": ">=10"
"node": ">=12.0.0"
},
"repository": "googleapis/nodejs-common",
"main": "./build/src/index.js",
Expand Down Expand Up @@ -38,7 +38,7 @@
"duplexify": "^4.1.1",
"ent": "^2.2.0",
"extend": "^3.0.2",
"google-auth-library": "^7.14.0",
"google-auth-library": "^8.0.2",
"retry-request": "^4.2.2",
"teeny-request": "^7.0.0"
},
Expand All @@ -56,15 +56,15 @@
"@types/tmp": "0.2.3",
"c8": "^7.1.0",
"codecov": "^3.6.5",
"gts": "^2.0.0",
"gts": "^3.1.0",
"linkinator": "^2.0.4",
"mocha": "^8.0.0",
"mocha": "^9.2.2",
"mv": "^2.1.1",
"ncp": "^2.0.0",
"nock": "^13.0.0",
"proxyquire": "^2.1.3",
"sinon": "^14.0.0",
"tmp": "0.2.1",
"typescript": "~3.8.3"
"typescript": "^4.6.4"
}
}
2 changes: 1 addition & 1 deletion system-test/install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const spawnp = (
args: string[],
options: cp.SpawnOptions = {}
) => {
return new Promise((resolve, reject) => {
return new Promise<void>((resolve, reject) => {
cp.spawn(command, args, Object.assign(options, {stdio: 'inherit'}))
.on('close', code => {
if (code === 0) {
Expand Down

0 comments on commit 3d5acce

Please sign in to comment.