-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change error message format to multiline #362
refactor: change error message format to multiline #362
Conversation
Is there any way this could be breaking? |
@JustinBeckwith I think if users did any kinds of string/regexp operations against the error message, it would definitely throw them for a loop. If preferable, I could just make some new custom errors in the BigQuery lib itself, but it would still be a breaking change in the same capacity, which would require a semver major bump. |
Can you do a before / after? |
@stephenplusplus if you go to the linked issue, there's a pretty good diff on the two. |
I didn't see it. Could you do one for here anyway in the opening post so it's easier for users and future us? :) |
@stephenplusplus I just updated the overview with some examples. PTAL! |
This does make it easier to read, but since we're here, we could probably kick it up a notch:
|
@stephenplusplus SGTM - PTAL :) |
@callmehiphop would you mind updating the first post with the new formatting? |
@stephenplusplus sure, done! |
Thanks so much for getting this done! Love how quickly you guys pick up and resolve issues. 🎉 |
Fixes googleapis/nodejs-bigquery#326
Using the following server error for the before/after
Before
After