Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: snapshot.delete() throws issue #251

Merged
merged 3 commits into from
Jan 24, 2019

Conversation

chux0519
Copy link
Contributor

also modified the related test case

Fixes #250

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 17, 2019
also modified the related test case
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 17, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 17, 2019
@stephenplusplus
Copy link
Contributor

Thank you! I added a line in our system tests to back up the test as well.

@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2019
@stephenplusplus stephenplusplus added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 17, 2019
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2019
@stephenplusplus
Copy link
Contributor

@JustinBeckwith the robots are fighting me on this one :)

@jkwlui jkwlui added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@jkwlui
Copy link
Member

jkwlui commented Jan 18, 2019

run npm run fix to make lint run :)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 18, 2019
@chux0519
Copy link
Contributor Author

run npm run fix to make lint run :)

Thank you for reminding! It seems the cla label should be manually changed by googler, again.

@jkwlui jkwlui added the cla: yes This human has signed the Contributor License Agreement. label Jan 22, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@jkwlui jkwlui removed the cla: no This human has *not* signed the Contributor License Agreement. label Jan 22, 2019
@jkwlui jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2019
@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2019
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 24, 2019
@stephenplusplus stephenplusplus merged commit dfd6507 into googleapis:master Jan 24, 2019
@stephenplusplus
Copy link
Contributor

Thank you, @chux0519!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants