fix(deps): update dependency yargs to v13 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
googlebot
added
the
cla: yes
stephenplusplus
approved these changes
Feb 12, 2019
callmehiphop
approved these changes
Feb 12, 2019
callmehiphop
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
ofrobots
reviewed
Feb 12, 2019
| @@ -17,7 +17,7 @@ | |||
| "dependencies": { | |||
| "@google-cloud/error-reporting": "^0.6.0", | |||
| "express": "^4.16.3", | |||
| "yargs": "^12.0.0" | |||
| "yargs": "^13.0.0" | |||
There was a problem hiding this comment.
Does it make sense for this to be in dependencies rather than devDependencies?
There was a problem hiding this comment.
As samples are today, yes. Each sample file is essentially a cli tool.
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
======================================
Coverage 96.1% 96.1%
======================================
Files 34 34
Lines 1695 1695
Branches 76 76
======================================
Hits 1629 1629
Misses 49 49
Partials 17 17Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^12.0.0->^13.0.0Release Notes
yargs/yargs
v13.1.0Compare Source
Features
Renovate configuration
馃搮 Schedule: "after 9am and before 3pm" (UTC).
馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.
鈾伙笍 Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "
rebase!".馃敃 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.