Skip to content

Commit

Permalink
fix: GoogleAdsError missing using generator version after 1.3.0 (#1526)
Browse files Browse the repository at this point in the history
[PR](googleapis/gapic-generator-typescript#878) within
updated gapic-generator-typescript version 1.4.0

Committer: @summer-ji-eng
PiperOrigin-RevId: 375759421

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue May 25 11:51:53 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 95fa72fdd0d69b02d72c33b37d1e4cc66d4b1446
Source-Link: googleapis/googleapis@95fa72f
  • Loading branch information
yoshi-automation committed May 29, 2021
1 parent c4096af commit adfe68e
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
2 changes: 2 additions & 0 deletions dev/src/v1/firestore_admin_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ export class FirestoreAdminClient {
}
if (!opts.fallback) {
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
} else if (opts.fallback === 'rest') {
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
}
if (opts.libName && opts.libVersion) {
clientHeader.push(`${opts.libName}/${opts.libVersion}`);
Expand Down
2 changes: 2 additions & 0 deletions dev/src/v1/firestore_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ export class FirestoreClient {
}
if (!opts.fallback) {
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
} else if (opts.fallback === 'rest') {
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
}
if (opts.libName && opts.libVersion) {
clientHeader.push(`${opts.libName}/${opts.libVersion}`);
Expand Down
2 changes: 2 additions & 0 deletions dev/src/v1beta1/firestore_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ export class FirestoreClient {
}
if (!opts.fallback) {
clientHeader.push(`grpc/${this._gaxGrpc.grpcVersion}`);
} else if (opts.fallback === 'rest') {
clientHeader.push(`rest/${this._gaxGrpc.grpcVersion}`);
}
if (opts.libName && opts.libVersion) {
clientHeader.push(`${opts.libName}/${opts.libVersion}`);
Expand Down
6 changes: 3 additions & 3 deletions synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/nodejs-firestore.git",
"sha": "aa92a1545a64e1164d5454c24fb38fb99aa1fd24"
"sha": "c4096affaa69017ff1515d02631fd68614605528"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "6fa858c6489b1bbc505a7d7afe39f2dc45819c38",
"internalRef": "372656503"
"sha": "95fa72fdd0d69b02d72c33b37d1e4cc66d4b1446",
"internalRef": "375759421"
}
},
{
Expand Down

0 comments on commit adfe68e

Please sign in to comment.