Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add List() API #368

Merged
merged 11 commits into from
Oct 2, 2018
Merged

Add List() API #368

merged 11 commits into from
Oct 2, 2018

Conversation

schmidt-sebastian
Copy link
Contributor

This adds support for the ListDocuments RPC, which allows us to enumerate all documents, including missing documents. We only return DocumentReference and don't fetch any data.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2018
@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt-list branch 3 times, most recently from 55663fb to 682eb09 Compare September 29, 2018 00:34
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshingly small PR. 😛

This basically LGTM, but we should probably hold off submitting until we discuss the API.

* } else {
* missingDocuments++;
* }
* }

This comment was marked as spam.

This comment was marked as spam.

@@ -135,6 +135,28 @@ describe('Collection interface', () => {
});
});

it('hast list() method', () => {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

* The document references returned may include missing documents, which
* are documents that have not been explicitly created but contain
* subcollections. If you attempt to read a missing document, we will return
* a DocumentSnapshot whose `.exists` property is set to false.

This comment was marked as spam.

This comment was marked as spam.

@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt-referencetest to master October 1, 2018 15:59
@ghost ghost assigned JustinBeckwith Oct 2, 2018
@mikelehen
Copy link
Contributor

Still LGTM.

@mikelehen mikelehen removed their assignment Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants