Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release @google-cloud/firestore v0.20.0 #522

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Release @google-cloud/firestore v0.20.0 #522

merged 2 commits into from
Jan 16, 2019

Conversation

JustinBeckwith
Copy link
Contributor

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2019
mikelehen
mikelehen approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One question about the changelog, but otherwise looks good.

CHANGELOG.md Outdated
01-16-2019 13:14 PST

### Bug Fixes
- refactor: change timestampsInSnapshots default to true.. ([#520](https://github.com/googleapis/nodejs-firestore/pull/520))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 16, 2019
@mikelehen mikelehen added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 16, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mikelehen
Copy link
Contributor

I consent to my changes being included so I've added the cla:yes label. :-)

@JustinBeckwith JustinBeckwith merged commit 43dfedf into googleapis:master Jan 16, 2019
@yoshi-automation
Copy link
Contributor

Release is at https://github.com/googleapis/nodejs-firestore/releases/tag/v0.20.0

@yoshi-automation
Copy link
Contributor

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@jkwlui jkwlui Awaiting requested review from jkwlui

Assignees
No one assigned
Labels
autorelease: published cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JustinBeckwith @googlebot @mikelehen @yoshi-automation