Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update sample to use non-default export #634

Merged
merged 3 commits into from
May 17, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

This keeps some of the improvements of #629 without breaking the default export.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 17, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 17, 2019
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #634 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   61.49%   61.49%           
=======================================
  Files          21       21           
  Lines        3420     3420           
  Branches      459      459           
=======================================
  Hits         2103     2103           
  Misses       1254     1254           
  Partials       63       63
Impacted Files Coverage Δ
dev/src/watch.ts 96.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62eaab0...f5129ba. Read the comment docs.

@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #634 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   61.49%   61.49%           
=======================================
  Files          21       21           
  Lines        3420     3420           
  Branches      459      459           
=======================================
  Hits         2103     2103           
  Misses       1254     1254           
  Partials       63       63
Impacted Files Coverage Δ
dev/src/watch.ts 96.52% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cc67f...4b34a81. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit bf3da23 into master May 17, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-samples branch May 17, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants