Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release nodejs-logging-bunyan v0.9.0 #131

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Release nodejs-logging-bunyan v0.9.0 #131

merged 2 commits into from
Aug 22, 2018

Conversation

JustinBeckwith
Copy link
Contributor

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 21, 2018
@ghost ghost assigned JustinBeckwith Aug 21, 2018
@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files           3        3           
  Lines         343      343           
  Branches       21       21           
=======================================
  Hits          291      291           
  Misses         52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8053a3f...f18e640. Read the comment docs.

@DominicKramer
Copy link
Contributor

I think we should wait until PR #122 lands before making a new release.

Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comment is addressed.


### Breaking changes
- fix: drop support for node.js 4.x and 9.x (#87)
- fix: drop support for node 4.x and 9.x (#69)

This comment was marked as spam.

@ofrobots
Copy link
Contributor

@DominicKramer if you think #122 can be completed soonish today, sure. If not, then we should not delay the release. This release is need to get the fix for #123 shipped.

@JustinBeckwith JustinBeckwith merged commit 059e642 into googleapis:master Aug 22, 2018
@JustinBeckwith
Copy link
Contributor Author

@ofrobots
Copy link
Contributor

The release still needs some more baby-sitting. I relaunched the system-tests because they were failing. https://circleci.com/workflow-run/fe299be4-9271-4532-b7b8-9cc718898a7b

@JustinBeckwith
Copy link
Contributor Author

Hmm. This is a process problem. We shouldn't even let the original PR pass CI if the nightly tests or sample tests are failing :(

In the case, I don't think it's a flake. The nightlies are actually not passing:
#132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants