-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release nodejs-logging-bunyan v0.9.0 #131
Release nodejs-logging-bunyan v0.9.0 #131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 84.83% 84.83%
=======================================
Files 3 3
Lines 343 343
Branches 21 21
=======================================
Hits 291 291
Misses 52 52 Continue to review full report at Codecov.
|
I think we should wait until PR #122 lands before making a new release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once comment is addressed.
|
||
### Breaking changes | ||
- fix: drop support for node.js 4.x and 9.x (#87) | ||
- fix: drop support for node 4.x and 9.x (#69) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@DominicKramer if you think #122 can be completed soonish today, sure. If not, then we should not delay the release. This release is need to get the fix for #123 shipped. |
The release still needs some more baby-sitting. I relaunched the system-tests because they were failing. https://circleci.com/workflow-run/fe299be4-9271-4532-b7b8-9cc718898a7b |
Hmm. This is a process problem. We shouldn't even let the original PR pass CI if the nightly tests or sample tests are failing :( In the case, I don't think it's a flake. The nightlies are actually not passing: |
This pull request was generated using releasetool.