Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate the code to typescript #18

Merged
merged 2 commits into from Jan 10, 2018
Merged

chore: migrate the code to typescript #18

merged 2 commits into from Jan 10, 2018

Conversation

DominicKramer
Copy link
Contributor

BREAKING CHANGE: As a result of the migration, the way in which this package is required and used has changed slightly.

That is, the package is required and a LoggingBuyan object is created as follows on Node 6+. In particular, note the {} braces used in the require statement and the use of new which is now mandatory.

const {LoggingBunyan} = require('@google-cloud/logging-bunyan');

// Creates a Bunyan Stackdriver Logging client
const loggingBunyan = new LoggingBunyan();

On Node 4, the require syntax is slightly different, but the use of new is still required.

const LoggingBunyan = require('@google-cloud/logging-bunyan').LoggingBunyan;

// Creates a Bunyan Stackdriver Logging client
const loggingBunyan = new LoggingBunyan();

Migrated src, test, samples and system test
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@ghost ghost assigned DominicKramer Jan 9, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2018
@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 9, 2018
@ofrobots ofrobots added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 9, 2018
@@ -128,14 +128,14 @@ jobs:
- run:
name: Install modules and dependencies.
command: |
npm install
npm install --unsafe-perm

This comment was marked as spam.

This comment was marked as spam.

@ofrobots ofrobots added the semver: major Hint for users that this is an API breaking change. label Jan 10, 2018
@ofrobots ofrobots changed the title chore: Migrate the code to Typescript chore: migrate the code to typescript Jan 10, 2018
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that I edited the issue title to fix capitalization. See https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#subject

@DominicKramer DominicKramer merged commit f6bab0f into master Jan 10, 2018
@stephenplusplus stephenplusplus deleted the typescript branch February 7, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. semver: major Hint for users that this is an API breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants