New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate the code to typescript #18
Conversation
Migrated src, test, samples and system test
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
.circleci/config.yml
Outdated
@@ -128,14 +128,14 @@ jobs: | |||
- run: | |||
name: Install modules and dependencies. | |||
command: | | |||
npm install | |||
npm install --unsafe-perm |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note that I edited the issue title to fix capitalization. See https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#subject
BREAKING CHANGE: As a result of the migration, the way in which this package is required and used has changed slightly.
That is, the package is required and a
LoggingBuyan
object is created as follows on Node 6+. In particular, note the{}
braces used in the require statement and the use ofnew
which is now mandatory.On Node 4, the require syntax is slightly different, but the use of
new
is still required.