fix: run tests with source map support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
assigned 
DominicKramer
approved these changes
Jan 10, 2018
|
Samples are all un-transpiled. Why do they need source-map-support? |
|
@ofrobots I was thinking that if there was a failure in the samples tests that was caused by an error being thrown in the underlying logging winston code, then source-map-support would translate the |
ofrobots
force-pushed
the
source-map-support
branch
from
fe16a4b
to
c554a10
Compare
|
@DominicKramer that's a fair point. Added. Will land once/if CI passes. |
|
@ofrobots Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.