Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

feat!: default to v1 of the API #88

Merged
merged 15 commits into from
Nov 26, 2021
Merged

feat!: default to v1 of the API #88

merged 15 commits into from
Nov 26, 2021

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented May 24, 2021

refactor!: v1 removes methods 'restoreCertificateAuthority', 'scheduleDeleteCertificateAuthority', 'getReusableConfig', 'listReusableConfigs'

@JustinBeckwith JustinBeckwith requested a review from a team as a code owner May 24, 2021 17:34
@product-auto-label product-auto-label bot added the api: security-privateca Issues related to the googleapis/nodejs-security-private-ca API. label May 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2021
@JustinBeckwith JustinBeckwith added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 24, 2021
@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2021
@bcoe
Copy link
Contributor

bcoe commented Jul 22, 2021

what's blocking landing this, should we reach out to the API team and ask if there are known breaking changes between v1beta and v1?

@JustinBeckwith JustinBeckwith removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 15, 2021
@JustinBeckwith
Copy link
Contributor Author

I no longer remember why this is blocked. It's probably worth asking the team :)

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@bcoe bcoe merged commit a52d838 into main Nov 26, 2021
@bcoe bcoe deleted the usev1 branch November 26, 2021 18:06
@release-please release-please bot mentioned this pull request Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: security-privateca Issues related to the googleapis/nodejs-security-private-ca API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants