This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
feat!: default to v1 of the API #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: security-privateca
Issues related to the googleapis/nodejs-security-private-ca API.
label
May 24, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
May 24, 2021
JustinBeckwith
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
May 24, 2021
sofisl
approved these changes
Jun 8, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 2, 2021
what's blocking landing this, should we reach out to the API team and ask if there are known breaking changes between v1beta and v1? |
JustinBeckwith
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Sep 15, 2021
I no longer remember why this is blocked. It's probably worth asking the team :) |
Warning: This pull request is touching the following templated files:
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: security-privateca
Issues related to the googleapis/nodejs-security-private-ca API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor!: v1 removes methods 'restoreCertificateAuthority', 'scheduleDeleteCertificateAuthority', 'getReusableConfig', 'listReusableConfigs'