Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only fail if session pool is full #752

Closed
wants to merge 1 commit into from

Conversation

olavloite
Copy link
Contributor

Only fail session creation if the pool is already full.

Fixes #751

See also:

it('should reuse sessions when fail=true', async () => {
and
if (this.isFull && this.options.fail!) {
in PR #743

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2019
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #752 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #752   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files          18       18           
  Lines       15622    15622           
  Branches      532      532           
=======================================
  Hits        15015    15015           
  Misses        602      602           
  Partials        5        5
Impacted Files Coverage Δ
src/session-pool.ts 99.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14aefff...6288235. Read the comment docs.

Copy link
Contributor

@hengfengli hengfengli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@olavloite
Copy link
Contributor Author

Closing in favor of #759 that also included this fix.

@olavloite olavloite closed this Dec 17, 2019
@olavloite olavloite deleted the issue-751 branch December 17, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set fail to true in pool session config leading to 'No resources available' error.
4 participants