feat: include potential leaked session stacktraces in error #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
+ Coverage 96.11% 96.11% +<.01%
==========================================
Files 18 18
Lines 15622 15636 +14
Branches 532 532
==========================================
+ Hits 15015 15029 +14
Misses 602 602
Partials 5 5
Continue to review full report at Codecov.
|
skuruppu
approved these changes
Dec 17, 2019
This was referenced Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error thrown by the session pool when it is exhausted should include the stacktraces of the checked out sessions. This information can be used to track down potential session leaks.
Fixes #758