Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in readme #1331

Merged
merged 2 commits into from
Nov 3, 2020
Merged

docs: fix typo in readme #1331

merged 2 commits into from
Nov 3, 2020

Conversation

tanmen
Copy link
Contributor

@tanmen tanmen commented Nov 2, 2020

I felt this was a misspelling, but I didn't understand.
If you misspell and find this fix useful, please incorporate my fix if you like.

I didn't create an issue because it's a small change.

@tanmen tanmen requested a review from a team as a code owner November 2, 2020 16:02
@google-cla
Copy link

google-cla bot commented Nov 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 2, 2020
@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1331 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1331   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          14       14           
  Lines       11719    11719           
  Branches      582      513   -69     
=======================================
  Hits        11602    11602           
  Misses        117      117           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde4328...d777c38. Read the comment docs.

@tanmen tanmen changed the title fix(docs): spee fix(docs): Document misspelling ("bencharmking") Nov 2, 2020
@tanmen
Copy link
Contributor Author

tanmen commented Nov 2, 2020

I just signed the cla.

@JustinBeckwith JustinBeckwith changed the title fix(docs): Document misspelling ("bencharmking") docs: fix typo in readme Nov 2, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Nov 3, 2020
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 3, 2020
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2020
@JustinBeckwith JustinBeckwith merged commit 7f3bb25 into googleapis:master Nov 3, 2020
@tanmen
Copy link
Contributor Author

tanmen commented Nov 4, 2020

@JustinBeckwith Thank you for review and marge X)
I so happy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants