Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): hmac key - service account pool and fix tests #810

Merged
merged 20 commits into from
Aug 14, 2019

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Aug 14, 2019

Credentials file is not longer needed since library is able to make request to create an HMAC key to a service account owned by gimme-acc.

@jkwlui jkwlui changed the base branch from master to hmac-sa-admin August 14, 2019 00:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2019
@jkwlui jkwlui changed the title feat(test): SA HMAC - service account pool and fix tests feat(test): hmac key - service account pool and fix tests Aug 14, 2019
@jkwlui jkwlui requested a review from frankyn August 14, 2019 00:42
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Samples are much cleaner. Thanks for cleaning them up!

@jkwlui jkwlui merged commit 28f5f33 into hmac-sa-admin Aug 14, 2019
@jkwlui jkwlui deleted the hmac-sa-admin-service-account-pool branch August 14, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants