chore: release 3.2.2

[yoshi-automation]

🤖 I have created a release *beep* *boop*

3.2.2 (2019-09-06)

Bug Fixes

• remove unsupported keepAcl param (#837) (5f69a3d)

---

This PR was generated with Release Please.

[codecov]

Codecov Report

Merging #839 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          11       11           
  Lines        1194     1194           
  Branches      296      296           
=======================================
  Hits         1137     1137           
  Misses         29       29           
  Partials       28       28

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f69a3d...7139530. Read the comment docs.

[jkwlui]

This release removed a field from an interface and can cause potential breakage for TypeScript user so I want to tread carefully here. @bcoe any thought on whether we should release this as a patch vs _?

[AVaksman]

To save time on research, the field in question slipped in the documentation inadvertently (was never meant to be part of it) see below.
#165 (comment)

[bcoe]

@jkwlui @AVaksman if I understand correctly, this parameter was ignored, but we'll potentially break folks who were using the old types? if they attempted to set this parameter?

My temptation is to instead add a warning message for folks setting this parameter:

if (options.hasOwnProperty('keepAcl')) {
  // TODO: remove keepAcl from interface in next major.
  console.warn('keepAcl parameter is not supported');
}

[AVaksman]

this parameter was ignored, but we'll potentially break folks who were using the old types? if they attempted to set this parameter?

That's my understanding.

My temptation is to instead add a warning message for folks setting this parameter:

if (options.hasOwnProperty('keepAcl')) {
  // TODO: remove keepAcl from interface in next major.
  console.warn('keepAcl parameter is not supported');
}

👍 👆
I don't mind adding warning instead.
Sounds reasonable to me

[bcoe]

@AVaksman awesome, let's take that approach; we should confirm that the warning message only happens if the user sets the value of keepAcl.