-
Notifications
You must be signed in to change notification settings - Fork 429
Conversation
upstream pull request is: googleapis/oauth2client#368
/cc @aeijdenberg |
@jay0lee: please merge commits. There's no need for this change to be spread across three commits. @aeijdenberg: would you be comfortable reviewing the content of this change? It's quite small. |
Hi Nathaniel, I wasn't actually aware that the OAuth endpoint version numbers had been bumped (I'm no longer working in that area). anthm@ might be a better choice to review? |
I was also not aware of these revisions. But since this is bringing it up to date with public documentation this Looks Good To Me. Before merging, can you make sure the new endpoints work with the library by exercising some example code? |
This is why @anthmgoogle The Travis merge build will also fail if it isn't valid |
@jay0lee: please squash commits? |
GOOGLE_AUTH_URI update as documented at: https://developers.google.com/identity/protocols/OAuth2UserAgent#formingtheurl GOOGLE_TOKEN_URI update as documented at: https://developers.google.com/identity/protocols/OAuth2InstalledApp#handlingtheresponse GOOGLE_TOKEN_INFO_URI update as documented at: https://developers.google.com/identity/protocols/OAuth2UserAgent#tokeninfo-validation -update client_secrets.json with new URIs -update unfilled_client_secrets.json with new URIs
Sorry for delay, commits are squashed now. |
Updated Google URIs.
GOOGLE_AUTH_URI update as documented at:
https://developers.google.com/identity/protocols/OAuth2UserAgent#formingtheurl
GOOGLE_TOKEN_URI update as documented at:
https://developers.google.com/identity/protocols/OAuth2InstalledApp#handlingtheresponse
GOOGLE_TOKEN_INFO_URI update as documented at:
https://developers.google.com/identity/protocols/OAuth2UserAgent#tokeninfo-validation