Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Updated Google URIs #368

Merged
merged 1 commit into from
Feb 5, 2016
Merged

Updated Google URIs #368

merged 1 commit into from
Feb 5, 2016

Conversation

jay0lee
Copy link
Contributor

@jay0lee jay0lee commented Dec 31, 2015

jay0lee added a commit to GAM-team/GAM that referenced this pull request Dec 31, 2015
@dhermes
Copy link
Contributor

dhermes commented Dec 31, 2015

/cc @aeijdenberg

@nathanielmanistaatgoogle
Copy link
Contributor

@jay0lee: please merge commits. There's no need for this change to be spread across three commits.

@aeijdenberg: would you be comfortable reviewing the content of this change? It's quite small.

@aeijdenberg
Copy link

Hi Nathaniel, I wasn't actually aware that the OAuth endpoint version numbers had been bumped (I'm no longer working in that area). anthm@ might be a better choice to review?

@anthmgoogle
Copy link

I was also not aware of these revisions. But since this is bringing it up to date with public documentation this Looks Good To Me.

Before merging, can you make sure the new endpoints work with the library by exercising some example code?

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2016

This is why tox -e system-tests exists 😀

@anthmgoogle The Travis merge build will also fail if it isn't valid

@nathanielmanistaatgoogle
Copy link
Contributor

@jay0lee: please squash commits?

GOOGLE_AUTH_URI update as documented at:
https://developers.google.com/identity/protocols/OAuth2UserAgent#formingtheurl

GOOGLE_TOKEN_URI update as documented at:
https://developers.google.com/identity/protocols/OAuth2InstalledApp#handlingtheresponse

GOOGLE_TOKEN_INFO_URI update as documented at:
https://developers.google.com/identity/protocols/OAuth2UserAgent#tokeninfo-validation

-update client_secrets.json with new URIs

-update unfilled_client_secrets.json with new URIs
@jay0lee
Copy link
Contributor Author

jay0lee commented Feb 5, 2016

Sorry for delay, commits are squashed now.

nathanielmanistaatgoogle added a commit that referenced this pull request Feb 5, 2016
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit ee06ffb into googleapis:master Feb 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants