Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Move conditionally defined ndb helpers into their own module. #434

Merged
merged 1 commit into from
Feb 25, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 23, 2016

Towards #433.


from google.appengine.ext import ndb

from oauth2client.client import Credentials

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor Author

dhermes commented Feb 24, 2016

@nathanielmanistaatgoogle PTAL, I addressed the comments. (UPDATE: Except for the one about string concat.)


from google.appengine.ext import ndb

from oauth2client import client as client_mod

This comment was marked as spam.

This comment was marked as spam.

@nathanielmanistaatgoogle
Copy link
Contributor

You addressed it just fine; a counterargument is a perfectly valid form of addressing a comment. :-)

Looks great otherwise (if you really want to keep the as client_mod, well it's in an internal place so that's fine). Squash, retest, and merge. :-)

@dhermes
Copy link
Contributor Author

dhermes commented Feb 24, 2016

Did the rename (UPDATE: specifically client_mod renamed back to client). Will squash and wait until the sun goes down for Travis

CredentialsNDBProperty = _appengine_ndb.CredentialsNDBProperty
FlowNDBProperty = _appengine_ndb.FlowNDBProperty
_NDB_KEY = _appengine_ndb.NDB_KEY
_NDB_MODEL = _appengine_ndb.NDB_MODEL

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

dhermes added a commit that referenced this pull request Feb 25, 2016
Move conditionally defined ndb helpers into their own module.
@dhermes dhermes merged commit 4b0a5ed into googleapis:master Feb 25, 2016
@dhermes dhermes deleted the move-ndb-into-module branch February 25, 2016 03:49
@dhermes dhermes mentioned this pull request Mar 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants