Update imports to only Packages or Modules #562
Conversation
|
I got all but one line down to under 80 characters. Without assigning temporary variables to shorten the line, it will take some refactoring beyond the scope of this PR to clean it up. I've posted some options in #556 on how to proceed. |
|
Just assign a temporary variable. Anything else isn't worth the headache |
|
Will do. I want to add a TODO to fix that, but need to reference something. I'm thinking of adding an issue to refactor the built-in credentials. It started as a small refactor in my head, but it's becoming bigger as I think about it more. |
|
Rebased branch, added issue #564, and updated this PR. |
|
@pferate this branch has conflicts, can you update? |
|
@jonparrott: Updated |
|
|
||
| urlpatterns += [url(r'^oauth2/', include(oauth2_urls))] | ||
| urlpatterns += [url(r'^oauth2/', include(site.oauth2_urls))] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
pferate
force-pushed
the
import_refactor
branch
3 times, most recently
from
f0087b3
to
ee4ea91
Compare
| @@ -56,6 +49,8 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| Credentials = client.Credentials | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Oof, that's a long code review. I keep forgetting that we have this much code in the library. Looks mostly good; just those few observations. |
Also cleaned up some nested attribute access.
|
Thanks @nathanielmanistaatgoogle! I've updated the PR, per your suggestions and rebased again. I mentioned this in another PR, but the |
|
Link to the |
|
The |
Also cleaned up some nested attribute access.
Resolves issue #556